Christopher Hunt

Results 109 comments of Christopher Hunt

> I think that more important than the number of maximum `PUBLISH` messages allowed to be queued for a given topic, it is not to end up with a broken...

I think then that the problem is within the consumer actor. At the moment, we are just letting subsequent publish messages to an active topic pass through.

> Another potential fix for that, would be as I understand you suggest, rejecting the second publish message to the same topic. Note that in this case it can potentially...

> Could you check my last comment? Any update on this? Really sorry for the delay. I'm not a fan of the fix proposed by the PR. Unfortunately, I'm a...

In the case of publishing from a client, I think that we can provide the equivalent to the ask pattern where a Future[Done] is returned. This is in addition to...

> In the case of publishing from a client, I think that we can provide the equivalent to the ask pattern where a Future[Done] is returned. This is in addition...

@ennru I've just updated the PR with the `ask` API. I'm actually now wondering though if both `tell` and `ask` should be rolled into one and named `offer` i.e. treat...

I'm getting some MiMa issues given the new APIs... these changes should be permitted though, right? After all, origin is a 2.0 branch and there won't be any intention of...

> Would the offer align well with Source.queue's offer? Would it fail for similar reasons eg. when buffers are full? Yeah, that’s what I was thinking...

@ennru This bit of code is essentially what we're doing today in production. The code completes the carry (which is a `Promise[Done]`) when the `PubAck` it is associated with is...