Hugues Devimeux

Results 21 comments of Hugues Devimeux

Hello and thanks for the review request. I was out of the loop for some time (this issue is more than **one** year old). I'm still not really in favour...

Did you correctly install `FFMPEG` ? To check run `ffmpeg --version`.

Hello and sorry, this went off my mind. I think the most straightforward and logical thing would be to exclude `ImageMobject` from being cached. The main reason is that such...

My proposal would be to generate a short random sequence as an, hash for every pixel_array, in order to invalidate the cache systematically. That's the most straightforward and simple solution...

Please add a [test](https://docs.manim.community/en/stable/contributing/testing.html) for that :)

That SGTM, but I'd rather wait for @behackl approval. Do you mind trying to add some test about that ? It's actually a corner case of manim interesting to test...

I strongly agree with this. Given that the vast majority of the methods that handle bezier curve logic only use one attribute of VMobject (`points`), it would make sense to...

Hello and thanks for the report ! This issue is a long date known issue, there is already one there #1524. I'm closing #1524 in favor of this one, more...

Note : the fix proposed by @AntonBallmaier in its original issue looks like a very clean way to do it. No idea wether it would work

> That's why coverage should be considered as integral part of the testing exercise. I agree with that