em-keyboard icon indicating copy to clipboard operation
em-keyboard copied to clipboard

Added -rs args and refactored cli.py

Open HoJLter opened this issue 6 months ago • 4 comments

What do you think about this?

P.S.: I also need to update the tests but I will do it later

Re:#176

HoJLter avatar May 02 '25 13:05 HoJLter

Done :)

HoJLter avatar May 02 '25 21:05 HoJLter

what about me?)

HoJLter avatar Jun 01 '25 07:06 HoJLter

Not forgotten, please be patient :)

hugovk avatar Jun 01 '25 10:06 hugovk

Codecov Report

:x: Patch coverage is 79.22078% with 16 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 80.14%. Comparing base (8bc2bc4) to head (300b0d3). :warning: Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/em/cli.py 75.75% 16 Missing :warning:

:exclamation: There is a different number of reports uploaded between BASE (8bc2bc4) and HEAD (300b0d3). Click for more details.

HEAD has 9 uploads less than BASE
Flag BASE (8bc2bc4) HEAD (300b0d3)
ubuntu-latest 7 0
macos-latest 7 6
windows-latest 7 6
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #178       +/-   ##
===========================================
- Coverage   91.40%   80.14%   -11.26%     
===========================================
  Files           3        3               
  Lines         128      136        +8     
===========================================
- Hits          117      109        -8     
- Misses         11       27       +16     
Flag Coverage Δ
macos-latest 80.14% <79.22%> (-9.70%) :arrow_down:
ubuntu-latest ?
windows-latest 80.14% <79.22%> (-9.70%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jun 01 '25 10:06 codecov[bot]

Please only do one thing in the PR: either add a new feature, or refactor without changing functionality. That will make it easier to review, as I'm not sure we do need a refactor. And we shouldn't need a large rewrite of tests when refactoring.

Also please make sure the tests pass, and try to include changes with test coverage.

hugovk avatar Jun 30 '25 13:06 hugovk