Hugo van Kemenade

Results 1426 comments of Hugo van Kemenade
trafficstars

At first glance, the docstring and constants have been in the codebase for 12 years (https://github.com/python-humanize/humanize/commit/0cf11999e31e2ce2e1adaa50134518ced7ef2aaf), but there's no test for googol, so sounds like a bug/regression. Possibly related to...

Thanks for the PR! I've made some updates, and because this is a new API, added an underscore to the function. (I'm considering adding underscores to the others too, and...

Hi, we need three things. First, use the language code "it_IT" rather than "Italian": `humanize.i18n.activate("it_IT")` Second, for `humanize.thousands_separator()` and `humanize.decimal_separator()`, we need to add `it_IT` into: https://github.com/python-humanize/humanize/blob/1feba83f1c0a64d63c15c52bdad75dfd064e8df8/src/humanize/i18n.py#L16-L27 Finally, `intword` doesn't...

No problem, I'll have a look when I gave time, unless someone else would like to check it :) And thanks for the other PRs.

Thanks, my guess is https://github.com/python-humanize/humanize/blob/main/tests/test_i18n.py could better handle activation and deactivation of `i18n`. PR welcome to improve it!

Thanks for the report, please could you create a pull request?

Thanks for the writeup and PR! I think we always want `truncate=True`, at least I don't think we'd ever want an extra "0 units" at the end. Are there any...

@dangillet Great to hear! I don't have anything in particular to prioritise, you could look at issues with "help wanted"/"good first issue" labels, or many comments, or 👍 reactions (you...

@novaTopFlex Please open a new issue if you have a specific problem.