transformers icon indicating copy to clipboard operation
transformers copied to clipboard

Fix `wandb` integration with `SetFit` model

Open timothepearce opened this issue 1 year ago • 4 comments

What does this PR do?

This PR fixes an error popping up while training a SetFitModelwhile reporting to wandb.

To fix this issue, we could also subclass and override the setup method specifically in the setfit repository, but that would be a much bigger job. @tomaarsen if think you're the one who should decide on that.

Fixes # (issue) https://github.com/huggingface/setfit/issues/498

Before submitting

  • [x] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • [x] Did you read the contributor guideline, Pull Request section?
  • [ ] Was this discussed/approved via a Github issue or the forum? Please add a link to it if that's the case.
  • [ ] Did you make sure to update the documentation with your changes? Here are the documentation guidelines, and here are tips on formatting docstrings.
  • [ ] Did you write any new necessary tests?

Who can review?

@tomaarsen @ArthurZucker

timothepearce avatar Apr 03 '24 16:04 timothepearce

@ArthurZucker Done!

timothepearce avatar May 01 '24 15:05 timothepearce

Just need the CIs to go Green 😉 you can rebase on main and run make fixup! 🤗

ArthurZucker avatar May 20 '24 09:05 ArthurZucker

@ArthurZucker That's what I did, but run_testsand ci/circleci: tests_tf are still failing, as it on the main branch. 😄

timothepearce avatar May 22 '24 09:05 timothepearce

Just re-triggered them!

ArthurZucker avatar May 23 '24 14:05 ArthurZucker

the test seems unrelated so I think we can merge!

ArthurZucker avatar Jun 19 '24 11:06 ArthurZucker

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.