transformers icon indicating copy to clipboard operation
transformers copied to clipboard

[WIP] Add PoNet

Open lxchtan opened this issue 2 years ago • 3 comments

What does this PR do?

Implementation of PoNet model (https://arxiv.org/abs/2110.02442).

Before submitting

  • [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • [x] Did you read the contributor guideline, Pull Request section?
  • [ ] Was this discussed/approved via a Github issue or the forum? Please add a link to it if that's the case.
  • [x] Did you make sure to update the documentation with your changes? Here are the documentation guidelines, and here are tips on formatting docstrings.
  • [x] Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR.

@ArthurZucker and @younesbelkada.

lxchtan avatar Apr 06 '23 08:04 lxchtan

cc @ArthurZucker and @younesbelkada

sgugger avatar Apr 06 '23 12:04 sgugger

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Hey! great work🔥

Would you be open to put this model on the hub following this tutorial! This model seems very similar to a Bert model, so it makes more sense! Especially for all the additional ressources that you want to add

ArthurZucker avatar Apr 28 '23 12:04 ArthurZucker

Thanks for your advice! I've followed the tutorial and put the codes to the hub.

lxchtan avatar May 11 '23 08:05 lxchtan

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Jun 04 '23 15:06 github-actions[bot]