tokenizers icon indicating copy to clipboard operation
tokenizers copied to clipboard

`cargo build` fails for python bindings when `--locked` is passed for `v0.15.1` and `v0.15.2`

Open CobaltCause opened this issue 1 year ago • 3 comments
trafficstars

I noticed that at least the git tags listed in the title forgot to update Cargo.lock in addition to Cargo.toml. This discrepancy causes cargo build --locked to fail with an error like this:

error: the lock file /.../tokenizers/bindings/python/Cargo.lock needs to be updated but --locked was passed to prevent this
If you want to try to generate the lock file without accessing the network, remove the --locked flag and use --offline instead.

Passing --locked is required for e.g. certain distro packaging methodologies. Also, it means that running cargo build without --locked will work but leave your git tree dirty, which is kinda weird.

Obviously this isn't really retroactively fixable, but hopefully this can be avoided in future releases. Maybe a check for this can be added in CI?

CobaltCause avatar Mar 22 '24 22:03 CobaltCause

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Apr 22 '24 01:04 github-actions[bot]

​

CobaltCause avatar Apr 22 '24 14:04 CobaltCause

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar May 23 '24 01:05 github-actions[bot]

This is fixed

ArthurZucker avatar Jun 11 '24 13:06 ArthurZucker