lerobot icon indicating copy to clipboard operation
lerobot copied to clipboard

update find_available_ports to use serial.tools.list_ports

Open meetsitaram opened this issue 1 year ago • 1 comments

What this does

Update dynamizel.py::find_available_ports to detect usb port connected to the dynamixel servos in multiple platforms - windows, mac and linux. The current approach of using Path("/dev").glob("tty*") was unable to detect ports in windows.

How it was tested

I tested the logic by running on a pc, mac as well as a linux virtual machine and was able to detect the port on all three platforms.

  • windows detected COM5
  • mac detected /dev/cu.usbmodel585A00081751
  • linux virtual machine detected /dev/ttyACM0

How to checkout & try? (for the reviewer)

This can be tested only when running the dynamixel script while connecting and disconnected the usb device.

python lerobot/common/robot_devices/motors/dynamixel.py

meetsitaram avatar Aug 22 '24 01:08 meetsitaram

@meetsitaram Thanks a lot for your PR, and for testing it on Mac, Linux and Windows.

We will work on merging it as soon as we added Continuous Integration on these 3 environments.

As of now we run CI on Linux only.

Cadene avatar Sep 12 '24 22:09 Cadene

Hello @meetsitaram, thanks for your contribution. Would you mind solving the conflicts? I think this function have changed location, but overall I would like to include this improvement

imstevenpmwork avatar Apr 17 '25 13:04 imstevenpmwork

This PR has been automatically marked as stale because it has not had recent activity (6 months). It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Oct 15 '25 02:10 github-actions[bot]

This PR was closed because it has been stalled for 21 days with no activity. Feel free to reopen if is still relevant, or to ping a collaborator if you have any questions.

github-actions[bot] avatar Nov 05 '25 02:11 github-actions[bot]