doc-builder icon indicating copy to clipboard operation
doc-builder copied to clipboard

add python version

Open anukaal opened this issue 3 years ago • 5 comments

can we add python version 3.8, 3.9 and 3.10 in test.yml ?

anukaal avatar Dec 22 '21 18:12 anukaal

is there specific reason you'd like to add those versions? if not, I'm gonna close this issue :)

mishig25 avatar Jan 11 '22 16:01 mishig25

is there specific reason you'd like to add those versions? if not, I'm gonna close this issue :)

To keep updated the version of the python , it would be great

anukaal avatar Jan 11 '22 16:01 anukaal

I'll let @LysandreJik decide

mishig25 avatar Jan 11 '22 16:01 mishig25

@sgugger can chime in if he disagrees, but I think testing for 3.7 and for 3.10 should give coverage for the versions in-between? Do you want to open a PR which adds a matrix for the 3.7/3.10 versions?

LysandreJik avatar Jan 12 '22 14:01 LysandreJik

I'm not entirely sure there is a point since the package doesn't use anything fancy, but okay to add 3.10.

sgugger avatar Jan 12 '22 14:01 sgugger