diffusers icon indicating copy to clipboard operation
diffusers copied to clipboard

Published 20 hours ago • verified publisher icon huggingface

Flax: trickle down `norm_num_groups`

Open pcuenca opened this issue 3 years ago • 4 comments

FlaxEncoder receives it here, but then it's ignored.

FlaxResnetBlock2D uses a hardcoded value.

Discovered by @younesbelkada in https://github.com/huggingface/diffusers/pull/589#discussion_r975796548

pcuenca avatar Sep 23 '22 10:09 pcuenca

Good point! Not sure how urgent at is but let's make sure we don't forget about it

patrickvonplaten avatar Oct 04 '22 22:10 patrickvonplaten

Maybe appropriate for hacktoberfest?

pcuenca avatar Oct 05 '22 11:10 pcuenca

Hello @pcuenca and @patrickvonplaten , I would like to try to take on this issue if that's alright.

akash5474 avatar Oct 08 '22 19:10 akash5474

Hey @akash5474,

This would be great!

patrickvonplaten avatar Oct 10 '22 13:10 patrickvonplaten

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Nov 03 '22 15:11 github-actions[bot]