diffusers icon indicating copy to clipboard operation
diffusers copied to clipboard

add stable_diffusion_walk notebook to example/community folder

Open danielpatrickhug opened this issue 3 years ago • 9 comments

Related issue: 205

Hello, this pull request is for adding the notebook stable_diffusion_walk to community examples. this notebook is designed to be run on google colab free version.

this notebook is self contained to google colab. this notebook is relatively easy to tweak parameters. this notebook's inference pipeline has one purpose only - to create videos. running this notebook should be relatively beginner friendly, tweaking it may not be.

@anton-l @patil-suraj @pcuenca or @patrickvonplaten may I please get a review? Please let me know if there are any other changes that can be made for this pull request.

danielpatrickhug avatar Sep 14 '22 20:09 danielpatrickhug

The documentation is not available anymore as the PR was closed or merged.

Hey there, I think we should add a community pipeline before adding the notebook? Idk. WDYT @anton-l - would it be better to add the community pipeline and then add the notebook here?

nateraw avatar Sep 16 '22 12:09 nateraw

Thanks a lot for the PR @danielpatrickhug ! As @nateraw said we should add a code file for community pipeline here and link to the colab from readme. The notebook can live in your repo, we don't add colab files in the repo because of the file size.

patil-suraj avatar Sep 22 '22 09:09 patil-suraj

No worries.

danielpatrickhug avatar Sep 22 '22 11:09 danielpatrickhug

Hey @danielpatrickhug,

I think the PR is still very relevant and nice, could I help you out here and make a pipeline that we'll then use from inside your colab?

patrickvonplaten avatar Sep 22 '22 13:09 patrickvonplaten

Hi @patrickvonplaten, sounds cool, sure what did you have in mind?

danielpatrickhug avatar Sep 22 '22 15:09 danielpatrickhug

@patrickvonplaten is it preferrable to:

  1. subclass StableDiffusionPipeline and update the __call__

or

  1. copy paste and call it something new, adding functionality within __call__

nateraw avatar Sep 22 '22 18:09 nateraw

Hey @nateraw,

It is preferrable to have the file as "independent" as possible meaning there shouldn't be any subclassing

patrickvonplaten avatar Sep 27 '22 09:09 patrickvonplaten

@danielpatrickhug I started working on the pipeline file here: https://huggingface.co/nateraw/stable-diffusion-walk/blob/main/pipeline.py

Pretty hacky version right now...needs some cleanup and maybe should remove some of the features that were in stable_diffusion_videos so it's cleaner.

nateraw avatar Oct 04 '22 16:10 nateraw

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Oct 29 '22 15:10 github-actions[bot]

I believe this can be closed now. Feel free to reopen if I'm missing something.

nateraw avatar Nov 01 '22 17:11 nateraw