httptoolkit-android icon indicating copy to clipboard operation
httptoolkit-android copied to clipboard

Improve layout avoid covering the buttons on low resolution devices

Open kaisar945 opened this issue 1 year ago • 1 comments

  • Before image
  • After image

kaisar945 avatar Mar 01 '24 07:03 kaisar945

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Mar 01 '24 07:03 CLAassistant

Oh, interesting! Thanks for the contribution @kaisar945, excellent point.

I do agree this is better than the current behaviour here where the buttons disappear, although it would be nice if there was no need to scroll, and we do have some unnecessary whitespace left here...

Do you think it's easy to shrink the whitespace (e.g. above the Connected text) just on small screens, to help with this? I think we'd want to use the scrollview too just as a backup for really small cases, but it would be nice to avoid needing that where possible.

Out of interest, what device are you using where you're seeing this, and what's the resolution? I thought I'd tested most common small sizes, but this is clearly smaller than I was expecting.

pimterry avatar Mar 04 '24 12:03 pimterry

Thank you for your reply, you are right I will try it.

This is my device resolution, it's not a real phone

Physical size: 480x960 Physical density: 240

kaisar945 avatar Mar 11 '24 02:03 kaisar945

I'm still interested in this! Do you think you'll have any time soon to investigate tweaking the whitespace here?

pimterry avatar Apr 01 '24 13:04 pimterry

Of course, I've been busy with work recently and almost forgot about this. I'll take some time to fix it as soon as possible.

kaisar945 avatar Apr 01 '24 16:04 kaisar945

Updated.

kaisar945 avatar Apr 10 '24 03:04 kaisar945

Thanks @kaisar945! Merged and released as v1.3.11 (building now, it'll be live on Google Play and auto-downloaded in HTTP Toolkit within a day or so)

pimterry avatar Apr 10 '24 14:04 pimterry

By the way, in case you're not aware, HTTP Toolkit Pro is free for contributors - I've set up an account linked to your Git commit email (j*.j*@gmail.com). Just click 'Get Pro' then 'Log into existing account' and enter your email there to log in. Thanks again!

pimterry avatar Apr 10 '24 15:04 pimterry

By the way, in case you're not aware, HTTP Toolkit Pro is free for contributors - I've set up an account linked to your Git commit email (j*.j*@gmail.com). Just click 'Get Pro' then 'Log into existing account' and enter your email there to log in. Thanks again!

Thank you for providing a powerful tool😃

kaisar945 avatar Apr 10 '24 15:04 kaisar945