http icon indicating copy to clipboard operation
http copied to clipboard

Release v6.0.0

Open ixti opened this issue 1 year ago • 9 comments

ixti avatar Aug 28 '24 15:08 ixti

@tarcieri if that looks good to you - I will cut the release

ixti avatar Aug 28 '24 15:08 ixti

Are there actually any breaking changes?

tarcieri avatar Aug 28 '24 18:08 tarcieri

I believe #776 and #783 are.

Also, I just noticed a PR that I wanted to merge 4 years ago and never get to it, that I believe we should add in the release. The change will be in how readpartial work to make it more IO-alike (raising EOFError when the end is reached instead of silent empty chunk). See: #618

ixti avatar Aug 28 '24 18:08 ixti

Alternative - I can cherry pick retriable and headers caching and cut 5.3.0 release instead.

ixti avatar Aug 28 '24 18:08 ixti

I’d definitely like to roll forward rather than backward, but v6.0.0 would be a great time to update the timeout subsystem: #773

tarcieri avatar Aug 28 '24 20:08 tarcieri

Will merge #773

ixti avatar Aug 28 '24 21:08 ixti

#773 is an issue, not a PR. Perhaps we should ping the people mentioned in that issue to see if they can open a PR, though

tarcieri avatar Aug 28 '24 21:08 tarcieri

Oh, I have confused it with #754 indeed

ixti avatar Aug 29 '24 02:08 ixti

I made a last call for breaking changes to the timeout subsystem in #773, though perhaps we should merge #754 first as well

tarcieri avatar Sep 05 '24 13:09 tarcieri

Hey @ixti! šŸ‘‹

I maintain the Peddler gem (Amazon SP-API client) and we'd love to use the :raise_error feature from #792 for our error handling. It's exactly what we need!

Since v6.0.0 seems blocked on breaking changes, would you consider that v5.3.0 release you mentioned in August? Cherry-picking the raise_error feature (plus retriable/headers caching) would help us and other downstream libraries adopt it immediately rather than waiting for v6.0.0.

Thanks for all the great work on HTTP! šŸ™

lineofflightagent avatar Jun 03 '25 23:06 lineofflightagent

After looking through the changes, I think it's fine to release 5.3.0 off the master by only excluding 1ba37c2, the rest looks fine for minor version bump. Doing that now

ixti avatar Jun 09 '25 02:06 ixti

Released v5.3.0; Closing this ticket, as I agree we should add as many breaking changes as we can to avoid making major bumps a habbit ;D

ixti avatar Jun 09 '25 03:06 ixti

Here's the list of backported commits: https://github.com/httprb/http/compare/v5.2.0...v5.3.0

ixti avatar Jun 09 '25 03:06 ixti