async-h1 icon indicating copy to clipboard operation
async-h1 copied to clipboard

Published 20 hours ago • verified publisher icon http-rs

dates

Open yoshuawuyts opened this issue 5 years ago • 9 comments

we should copy the impl from here https://crates.io/crates/httpdate (or use as a dep, unsure which is better)

yoshuawuyts avatar Nov 10 '19 01:11 yoshuawuyts

Seeing as this crate is no longer maintained (at least not within 2 years) I think we should copy the implementation.

technetos avatar Nov 17 '19 17:11 technetos

@technetos yeah I agree; let's do that!

yoshuawuyts avatar Nov 19 '19 20:11 yoshuawuyts

Can we close this?

technetos avatar Nov 20 '19 18:11 technetos

@technetos we're not actually using the dates implementation. Perhaps we should do that before closing this?

rylev avatar Nov 21 '19 10:11 rylev

Totally

technetos avatar Nov 21 '19 13:11 technetos

@dignifiedquire I believe you last looked at this; do you know where we're at with this?

yoshuawuyts avatar Jan 13 '20 15:01 yoshuawuyts

@yoshuawuyts AFAIK the client is not making use of the date header at all and the server is currently sending the date header on every response.

technetos avatar Jan 13 '20 16:01 technetos

Ah okay, so we probably should set the header from the client, right?

yoshuawuyts avatar Jan 14 '20 00:01 yoshuawuyts

Is there remaining work that this issue represents or can it be closed?

jbr avatar Jan 25 '21 22:01 jbr