ember-gestures icon indicating copy to clipboard operation
ember-gestures copied to clipboard

Remove dead code

Open lolmaus opened this issue 8 years ago • 3 comments

Hi!

I've discovered addon/components/slide-toggle which hasn't been updated since 2015, isn't documented and is like non-functional.

Until Ember CLI supports tree shaking, this dead code increases app's distro size.

Please remove it. You can keep it in a branch.

lolmaus avatar Sep 07 '17 12:09 lolmaus

There's probably more dead code like that.

lolmaus avatar Sep 07 '17 13:09 lolmaus

and is like non-functional. There's probably more dead code like that.

LOL - nicely put - yes, i was just in this lib for a couple hours digging out issue w/ pr 102 - saw some dead soldiers - we should probably use something like broccoli-concat-analyser then go from there.

Open to PR for low hanging fruit, like slide-toggle

eriktrom avatar Sep 08 '17 05:09 eriktrom

(also i didn't write this lib and dont actually use it in prod, so would be better if someone who does removed the code - i'm not sure what is and is not used without going file by file, fyi)

eriktrom avatar Sep 08 '17 05:09 eriktrom