ember-cli-changelog icon indicating copy to clipboard operation
ember-cli-changelog copied to clipboard

Feature Request: Add changelog to release notes.

Open seawatts opened this issue 9 years ago • 6 comments

I feel like there has to be some coordination between ember-cli-release and this changelog. It would be cool if ember-cli-release could actually create a github release. And then this could add the changelog to the release notes. Similar to how ember-cli does their releases.

Thoughts?

seawatts avatar Feb 04 '16 20:02 seawatts

@seawatts this is already built in, but a tighter integration is coming. The default blueprint should have installed the hook into your release config.

runspired avatar Feb 04 '16 23:02 runspired

@runspired do you mean that it will annotate a tag and then if you go to github and click draft new release, the changelog will be prepopulated by the selected tag.

seawatts avatar Feb 05 '16 17:02 seawatts

@seawatts when you ember release, it uses the beforeCommit hook to ask you if you want to generate the changelog for the release, then does so, then prompts you to make any final alterations, then adds it to the commit files for the release.

runspired avatar Feb 05 '16 17:02 runspired

Realizing we may be talking about different things here.

runspired avatar Feb 05 '16 17:02 runspired

@seawatts Are you talking about this type of github release?

If so, it seems like that would be it's own addon since it would have to deal with github's API. That said, if that addon could use an ember-cli-changelog hook to get the full log entry for a given release, that'd help make that an easier addon, right?

ryanjm avatar Apr 04 '16 00:04 ryanjm

Yes I am. But this is already using the github api https://github.com/runspired/ember-cli-changelog/blob/21de29fda5f9610b90b15c88b4a11b5f528f60a6/lib/helpers/git/github/compare-commits.js#L4

seawatts avatar Apr 14 '16 00:04 seawatts