cppfront icon indicating copy to clipboard operation
cppfront copied to clipboard

[SUGGESTION] Refactorings for to_cpp1.h file

Open dutkalex opened this issue 1 year ago • 5 comments
trafficstars

This PR contains a handful of small helper extractions to simplify the to_cpp1.h file, which reduces its length by about 1000 lines. Indeed, this file is very long and I believe that there are a lot of low hanging fruits like these ones... What do you think about that?

dutkalex avatar Mar 31 '24 14:03 dutkalex

Behavior should be exactly the same, to the notable exception of the value of source_loaded in the case of a wrong file extension. Indeed, with the current implementation source_loaded == true in that case although file loading is bypassed, which I believe is a bug...

dutkalex avatar Mar 31 '24 14:03 dutkalex

Thanks for your pull request! It looks like this may be your first contribution to cppfront. I need to send you the Contributor License Agreement (CLA) but I don't have your email address -- please email me at first dot last at gmail. Once it's signed I can look at your pull request. Thanks again for your contribution.

hsutter avatar May 08 '24 00:05 hsutter

@hsutter email sent :)

dutkalex avatar May 08 '24 09:05 dutkalex

It seems like something went wrong here, but I won't try to fix it without knowing first if this is something you are interested in...

dutkalex avatar May 11 '24 14:05 dutkalex

Seems like the problem has been fixed...

dutkalex avatar May 13 '24 14:05 dutkalex