Herb Sutter comments

Results 239 comments of


                                            Herb Sutter

R.5 (scoped objects): Do not warn on a const `unique_ptr<T[]>`

Editors call: Looks good, thank you!

Address not_null design question

Editors' call: This set of issues deserves a new look at whether `not_null` should be a general type, a type that works only on raw pointers, or an alias. GDR...

Should narrowing do something special for integer types (was: Should narrowing failures throw)

Editors' call: Our view is that `narrow` is like `to_integer(string)` -- if the input contains an invalid value (e.g., `to_integer("hello")`) then we should throw a run-time error. This means that...

Should narrowing do something special for integer types (was: Should narrowing failures throw)

Editors' call: The original question has been answered, but there is now a new question about integer casts and whether to make a special form of narrow/narrow_cast for them. Assigned...

ES.75 - Exception when defining function-like macros?

Editors call: We think this is covered by ES.31. Thanks!

Using f as function name and internal variables invites confusion. Recommending using better name for functions.

Editors call: Sure, let's change `f(...)` to `func(...)`. Thanks!

Consider amending SF.1 and not recommending .h extensions by default

Editors call: We agree this should be a "naming and layout / if you have no better convention already" rule, which is what NL is for. It should be moved...

[SUGGESTION][FIX] Add support for raw string literals in mixed mode

I actually completely forgot about raw string literals... thanks for doing this. At first blush this looks good, before merging let me take a deeper look with a fresh brain...

[FIX] preserve parens around expressions calculating value of argument for a function call

Good fix -- this actually corrects the output for two existing test cases, one of which is `mixed-test-parens.cpp2` that I hadn't noticed had the wrong output. As Bjarne would say:...

UFCS: function call starts UFCS chaining

(Repeating from #17) Interim ack: Thanks! Yes, I've been meaning to add chaining. I was thinking of implementing it later in the same function and remove this special case part...