hse icon indicating copy to clipboard operation
hse copied to clipboard

Published 20 hours ago • verified publisher icon hse-project

Consolidate CLI output functions

Open tristan957 opened this issue 2 years ago • 4 comments

It seemed like every tool defined its own syntax() and/or fatal(). By making a single a definition for each in libhse-cli, we can cut down all the redefinitions.

This also has the added benefit of reducing the number of tools needing tools/common.c. Less compilation. Yay!

tristan957 avatar Feb 16 '23 22:02 tristan957

Not in love with output.h, so if someone has a better name I am all for it!

tristan957 avatar Feb 16 '23 22:02 tristan957

A rare PR where I remove lines of code...

tristan957 avatar Feb 16 '23 22:02 tristan957

~Last PR. No Mas.~

Changing my mind. Rejecting this PR. This RC is baked. Can't change 45 files hours before QA kicks off a round of tests.

alexttx avatar Feb 17 '23 15:02 alexttx

Don't really care if it makes it into the rc. Just posting it to be merged eventually.

tristan957 avatar Feb 17 '23 17:02 tristan957