iptools icon indicating copy to clipboard operation
iptools copied to clipboard

Published 20 hours ago • verified publisher icon hrbrmstr

longs?

Open Ironholds opened this issue 8 years ago • 5 comments

The codebase now includes those. Do we have that supported, R-side?

Ironholds avatar Jan 16 '17 02:01 Ironholds

"those"?

hrbrmstr avatar Jan 16 '17 12:01 hrbrmstr

oh, "longs". perhaps a bit more exposition might help clarify the question for me.

hrbrmstr avatar Jan 16 '17 12:01 hrbrmstr

Oop, yep. So we have a lot of functions returning say std::vector < std::long > ... or accepting those as arguments. Do we have R-side support uniformly for that? I wasn't aware base was now cool with longs as a general thing.

Ironholds avatar Jan 16 '17 13:01 Ironholds

As long as it isn't an unsigned long, aye.

is.integer(2147483647L)
## TRUE

is.integer(4294967295L)
## FALSE

(I did not test that everywhere)

which means we may need to re-think the params/returns since IPv4 conversions are going to beed the full unsigned space.

hrbrmstr avatar Jan 16 '17 16:01 hrbrmstr

Mmmn yeah. Would using doubles make more sense/give us enough space? Also means we can build in the NA support.

Ironholds avatar Jan 16 '17 16:01 Ironholds