HP van Braam

Results 20 comments of HP van Braam
trafficstars

This is due to https://github.com/emscripten-ports/SDL2/issues/99, a simple fix is to add `-s DISABLE_DEPRECATED_FIND_EVENT_TARGET_BEHAVIOR=0` to src/Makefile.am `dosbox_LDFLAGS`. My fork has this fix: https://github.com/hpvb/em-dosbox

Thanks a lot for this! I needed some of these features.

I think this is caused by the "cleanup" script to reduce the size of the SDK tarball. There's a list of files to keep and I think I haven't included...

This should be fixed in 7810288c77e4f0f610aef01f093d052cae848835

Why is msvc still a garbage fire...

I'm not sure I like the new INEQUALITY_OPERATOR macro, we don't have those for other operators. It feels out of place and a little confusing. It kind of smells like...

> The alternative is adding a bunch of cpp20 conditionals everywhere. It wouldn't be dealbreaking, but I wasn't sure if that was desired when starting off I think we should...

> To clarify, this _isn't_ using C++20 features. This is only introducing fixes to make C++20 compilation work outright. Actually adding c++20 functionality wasn't within the original scope of the...

Well, I'm not the final arbiter of this decision. But I think my preference would go to a PR that just sets our minimum compiler to c++20, and makes these...