sacremoses icon indicating copy to clipboard operation
sacremoses copied to clipboard

Published 20 hours ago • verified publisher icon hplt-project

Restrict click to be <8.1

Open alecbrick opened this issue 3 years ago • 3 comments

Many projects use versions of click that aren't 8.0, and we should allow that. Ideally, we should also figure out what caused 8.1.3 to break.

Also, apparently 8.0.0 is broken.

alecbrick avatar May 02 '22 22:05 alecbrick

I think rolling back to 7.0 for click would be better. After considering the different options.

alvations avatar May 02 '22 23:05 alvations

Our project uses both sacremoses (through Huggingface) and click==8.0.4, which will cause problems

alecbrick avatar May 02 '22 23:05 alecbrick

just saw your issue comment, if you intend to replace the click requirement that'd be fantastic!

alecbrick avatar May 03 '22 00:05 alecbrick

Closing this for now, since both click 7 and 8 are okay and none are specifically required. I'm rather replacing click entirely with the default argparse than trying to fit this particular corner of dependency hell.

jelmervdl avatar Sep 27 '23 13:09 jelmervdl