schulcloud-flutter icon indicating copy to clipboard operation
schulcloud-flutter copied to clipboard

Published 20 hours ago • verified publisher icon hpi-schul-cloud

Make SortFilterSheet scrollable

Open ctiedt opened this issue 5 years ago • 3 comments
trafficstars

Closes: #260

This should for now fix the issue. However, ideally this change would be made in the black_hole_flutter package so that we could use the FancyBottomSheet from there.

ctiedt avatar Oct 04 '20 20:10 ctiedt

:warning: Unicorn Report

:warning: 1 Warning

  • Merge branch 'master' into issue/260-make-sortfiltersheet-scrollable

:information_source: 1 Info

  • This PR will close the following issues: #260

Generated by :unicorn: Unicorn
Report an issue

github-actions[bot] avatar Oct 04 '20 20:10 github-actions[bot]

Flutter Analyze found 0 issues ✅

Generated by :no_entry_sign: Danger

github-actions[bot] avatar Oct 04 '20 20:10 github-actions[bot]

I've updated this PR to use the latest Flutter version and added the missing drag indicator to the bottom sheet. Ideally, the sheet should not be scrollable when there isn't enough content that it is necessary, hence I won't yet add this functionality to black_hole_flutter.

JonasWanke avatar Oct 16 '20 11:10 JonasWanke