react-native-twilio-programmable-voice
react-native-twilio-programmable-voice copied to clipboard
hoxfon
Play disconnect sound android
changes to play disconnect.wav on disconnect(). instantiated soundPoolManager in constructor of TwilioVoiceManager.java since .wav file needs time to be loaded and parsed per Android Dev recommendation. Instantiated soundPoolManager in the constructor also seems to result in better sound quality for other SoundPoolManager related tasks compared to creating an instance at runtime with SoundPoolManager.getInstance(getReactApplicationContext()). I also added a few generated files to .gitignore
Nice improvement, I will look at merging this PR after other PR that have precedence, because they implement Twilio new libraries.
Thank you for your PR and our apologies it has been quiet on this PR for so long. Please read #158 for a general update on what's happening in this repo.
I have a few questions about this PR:
- Why would we not just have the react-native application play a sound on disconnect instead of android natively?
- Since a large PR has been merged recently, can you resolve the conflicts so we can test this?
Many thanks for your efforts!
It's been so long since I've worked on this that I'm not entirely sure what the best answer is to your first question but it sounds like a fine solution. With my current workload, I don't have time to work on this.
@gentleShark I understand! No worries, for now I will add this PR as a backlog item so it can be merged eventually.
Thanks for your efforts! I will leave this open for now.