tasking-manager
tasking-manager copied to clipboard
chore(frontend): migrate to TypeScript and Vite
What type of PR is this? (check all applicable)
- [x] 📝 Documentation
- [x] 🧑💻 Refactor
- [x] 🤖 Build or CI
Related Issue
Fixes #6533 Fixed #6531
Describe this PR
A brief description of how this solves the issue.
Screenshots
Please provide screenshots of the change.
Alternative Approaches Considered
Did you attempt any other approaches that are not documented in code?
Review Guide
Notes for the reviewer. How to test this change?
Checklist before requesting a review
- 📖 Read the Tasking Manager Contributing Guide: https://github.com/hotosm/tasking-manager/blob/develop/docs/developers/contributing.md
- 📖 Read the HOT Code of Conduct: https://docs.hotosm.org/code-of-conduct
- 👷♀️ Create small PRs. In most cases, this will be possible.
- ✅ Provide tests for your changes.
- 📝 Use descriptive commit messages.
- 📗 Update any related documentation and include any relevant screenshots.
- 🔠 Does this PR introduce or change any environment variables? If so, make sure to specify this change in the description.
[optional] What gif best describes this PR or how it makes you feel?
Quality Gate failed
Failed conditions
4 Security Hotspots
C Reliability Rating on New Code (required ≥ A)
See analysis details on SonarCloud
Catch issues before they fail your Quality Gate with our IDE extension
SonarLint
hey @JoltCode, how's the progress going on with this? have you set a timeframe for this to complete? cc - @htulipe @ramyaragupathy @manjitapandey
hey @JoltCode, how's the progress going on with this? have you set a timeframe for this to complete? cc - @htulipe @ramyaragupathy @manjitapandey
Hey, apologies, been a bit stuck on time! I haven't, but would be more than happy to set a timeframe!
Feel free to shoot me a DM on Slack as well! 😄
Hey, apologies, been a bit stuck on time! I haven't, but would be more than happy to set a timeframe!
I think it's going to take a lot of time since it's a very strenuous task. Can you come up with a timeframe according to your availability with this PR, or we may sit on a call if you would like to discuss anything related to it?
Hey, apologies, been a bit stuck on time! I haven't, but would be more than happy to set a timeframe!
I think it's going to take a lot of time since it's a very strenuous task. Can you come up with a timeframe according to your availability with this PR, or we may sit on a call if you would like to discuss anything related to it?
Yeah it is a pretty hefty task! Sure, I'd be more than happy to call and discuss! 👍
We had a call about this just now @royallsilwallz
The initial requirement to get this done quickly has passed, as we managed a workaround / fix for the PR that was dependent on this.
As this is such a big undertaking, it makes sense to subdivide into smaller PRs.
Near term goals:
- Fix merge conflicts here.
- Wrap up the changes in this PR.
- Ensure all frontend tests pass and Github workflows are happy.
- Test changes in this PR from the whole team (perhaps even community testing).
Long term goals:
- Continue where this PR left off.
- Make subsequent PRs upgrading JS --> TS incrementally.
Let me know if I can give an hand on that
Thanks for the offer @htulipe !
Are you on the HOTOSM Slack by the way? It might be easier to coordinate in a group chat 🙏
Merge conflicts resolved! 😄
We have the greenlight to test this branch on the dev server.
The line here needs to be modified: https://github.com/hotosm/tasking-manager/blob/develop/.circleci/config.yml#L456C22-L456C43
Then the branch will deploy for testing
Quality Gate failed
Failed conditions
21 Security Hotspots
C Reliability Rating on New Code (required ≥ A)
See analysis details on SonarQube Cloud
Catch issues before they fail your Quality Gate with our IDE extension
SonarQube for IDE
Continued with #6715