tasking-manager icon indicating copy to clipboard operation
tasking-manager copied to clipboard

chore(frontend): migrate to TypeScript and Vite

Open JoltCode opened this issue 1 year ago • 1 comments

What type of PR is this? (check all applicable)

  • [x] 📝 Documentation
  • [x] 🧑‍💻 Refactor
  • [x] 🤖 Build or CI

Related Issue

Fixes #6533 Fixed #6531

Describe this PR

A brief description of how this solves the issue.

Screenshots

Please provide screenshots of the change.

Alternative Approaches Considered

Did you attempt any other approaches that are not documented in code?

Review Guide

Notes for the reviewer. How to test this change?

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

JoltCode avatar Aug 20 '24 21:08 JoltCode

Quality Gate Failed Quality Gate failed

Failed conditions
4 Security Hotspots
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

sonarqubecloud[bot] avatar Aug 24 '24 14:08 sonarqubecloud[bot]

hey @JoltCode, how's the progress going on with this? have you set a timeframe for this to complete? cc - @htulipe @ramyaragupathy @manjitapandey

royallsilwallz avatar Nov 21 '24 05:11 royallsilwallz

hey @JoltCode, how's the progress going on with this? have you set a timeframe for this to complete? cc - @htulipe @ramyaragupathy @manjitapandey

Hey, apologies, been a bit stuck on time! I haven't, but would be more than happy to set a timeframe!

Feel free to shoot me a DM on Slack as well! 😄

JoltCode avatar Nov 21 '24 20:11 JoltCode

Hey, apologies, been a bit stuck on time! I haven't, but would be more than happy to set a timeframe!

I think it's going to take a lot of time since it's a very strenuous task. Can you come up with a timeframe according to your availability with this PR, or we may sit on a call if you would like to discuss anything related to it?

royallsilwallz avatar Nov 22 '24 04:11 royallsilwallz

Hey, apologies, been a bit stuck on time! I haven't, but would be more than happy to set a timeframe!

I think it's going to take a lot of time since it's a very strenuous task. Can you come up with a timeframe according to your availability with this PR, or we may sit on a call if you would like to discuss anything related to it?

Yeah it is a pretty hefty task! Sure, I'd be more than happy to call and discuss! 👍

JoltCode avatar Nov 30 '24 22:11 JoltCode

We had a call about this just now @royallsilwallz

The initial requirement to get this done quickly has passed, as we managed a workaround / fix for the PR that was dependent on this.

As this is such a big undertaking, it makes sense to subdivide into smaller PRs.

Near term goals:

  • Fix merge conflicts here.
  • Wrap up the changes in this PR.
  • Ensure all frontend tests pass and Github workflows are happy.
  • Test changes in this PR from the whole team (perhaps even community testing).

Long term goals:

  • Continue where this PR left off.
  • Make subsequent PRs upgrading JS --> TS incrementally.

spwoodcock avatar Dec 06 '24 10:12 spwoodcock

Let me know if I can give an hand on that

htulipe avatar Dec 06 '24 17:12 htulipe

Thanks for the offer @htulipe !

Are you on the HOTOSM Slack by the way? It might be easier to coordinate in a group chat 🙏

spwoodcock avatar Dec 13 '24 14:12 spwoodcock

Merge conflicts resolved! 😄

JoltCode avatar Dec 17 '24 13:12 JoltCode

We have the greenlight to test this branch on the dev server.

The line here needs to be modified: https://github.com/hotosm/tasking-manager/blob/develop/.circleci/config.yml#L456C22-L456C43

Then the branch will deploy for testing

spwoodcock avatar Jan 07 '25 23:01 spwoodcock

Quality Gate Failed Quality Gate failed

Failed conditions
21 Security Hotspots
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

sonarqubecloud[bot] avatar Jan 08 '25 11:01 sonarqubecloud[bot]

Continued with #6715

royallsilwallz avatar Feb 09 '25 18:02 royallsilwallz