Update query-string to v8.1.0 from v7.1.3

[tsmock]

The major change is that it is now pure ESM and no longer exports specific functions. It also requires Node.js 14+.

[HelNershingThapa]

This babel-loader problem occurred to me. Does it compile successfully at your end?

Failed to compile.

./node_modules/query-string/base.js 422:14
Module parse failed: Unexpected token (422:14)
File was processed with these loaders:
 * ./node_modules/babel-loader/lib/index.js
You may need an additional loader to handle the result of these loaders.
| 
|   return {
>     url: url_?.split('?')?.[0] ?? '',
|     query: parse(extract(url), options),
|     ...(options && options.parseFragmentIdentifier && hash ? {

[tsmock]

It did. But I hadn't wiped the node_modules directory, so maybe there was a required component there. I'll debug and (probably) push a new yarn.lock file.

[tsmock]

Well, rm -rf node_modules && yarn install && yarn build worked for me.

Maybe there is a version issue? My tool versions are:

• nodejs: 16.20.0
• yarn: 1.22.19

[eternaltyro]

LGTM. @HelNershingThapa can you verify that the rm node_modules workaround fixes the issue for us?

[HelNershingThapa]

@tsmock @eternaltyro, I'm having issues with yarn start specifically. yarn build works fine for me.

[eternaltyro]

@HelNershingThapa what exactly is the issue? Please include logs when you report issues .

[tsmock]

I was able to reproduce @HelNershingThapa's issue (from comment 2) with rm -rf node_modules && yarn install && yarn build && yarn start.

The important bit was yarn start. I think the comment "[does] it compile successfully at your end" caused a communication problem; I thought @HelNershingThapa was talking about the yarn build command when he was talking about the yarn start command.

Anyway, I'm rebuilding the yarn.lock file right now (rm -rf node_modules && rm yarn.lock && yarn install && yarn build && yarn start), and then I'll see if that fixed the problem.

[tsmock]

In other news, yarn build is giving the following message:

Creating an optimized production build...
One of your dependencies, babel-preset-react-app, is importing the
"@babel/plugin-proposal-private-property-in-object" package without
declaring it in its dependencies. This is currently working because
"@babel/plugin-proposal-private-property-in-object" is already in your
node_modules folder for unrelated reasons, but it may break at any time.

babel-preset-react-app is part of the create-react-app project, which
is not maintianed anymore. It is thus unlikely that this bug will
ever be fixed. Add "@babel/plugin-proposal-private-property-in-object" to
your devDependencies to work around this error. This will make this message
go away.

This doesn't quite jive with the create-react-app repository history (that issue was fixed two weeks ago), with a caveat that the CRA repo has had minimal activity for quite some time.

[tsmock]

Upstream (CRA) issue: https://github.com/facebook/create-react-app/issues/9468 . It looks like I might want to see if I can update react-scripts to 5.0.x first. Which will involve CRACO, since there are issues with SVG imports in CRA 5.x.

[tsmock]

Updating to CRA (react-scripts) to 5.0.1 fixes the issue with yarn start. I'll open a separate PR for that, since I'm going to need to fiddle with some code splitting (main.*.js is 6.07 MB, 2.35 MB from polyfill.js).

[sonarqubecloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.1% Duplication

[ramyaragupathy]

@tsmock @varun2948 would this be next in line after #5721? cc @royallsilwallz @emi420 @manjitapandey

[tsmock]

No; #5721 also updates query-string and includes all of the changes from this PR. See package.json#L43.

[tsmock]

This PR is no longer necessary; the same changes were part of #5721.