Pieter Hoste

Results 348 comments of Pieter Hoste

> Both the merged and the normal files are getting generated anyways. Ah, I wasn't aware of this, sorry, request sound reasonable then :)

@engcom-November: the issue is not about errors in the console The issue is about having the ability to disable JS bundling, or merging or minifying in the admin storeview only....

@engcom-Dash: it kind of looks good I think (not sure why files aren't bundled in the admin that sounds like a problem still). But next to this test, can you...

@denysaw-gaming: There should be an `Unsubscribe` button on the right side of this ticket. If there is only a `Subscribe` button, press it and then press `Unsubscribe` afterwards, that should...

This following issue sounds related to this fix: https://github.com/magento/magento2/issues/30012, can you confirm @MateuszMesek? If they are related, we should link this PR to that issue.

@engcom-November, what do you mean it doesn't come with a Magento installation? Yes it does, see [here](https://github.com/magento/magento2/blob/5dc13c3d81c0aa7164b06c08980aef4b779388a6/composer.lock#L12106-L12179)... @francisco-serfe: does it still trigger even if you update phpunit to the latest...

Well, reason I'm asking is because I think this was fixed in phpunit 9.5.25, when you can confirm, we don't need to reopen this issue 🙂

Okay, thanks for confirming! @engcom-November, @sdzhepa: I believe this issue needs to be reopened...

@engcom-Bravo: what was the reason for closing this? Please always specify a reason when closing issues in the future, otherwise it's confusing the people who watch the ticket. /cc @sdzhepa...

@engcom-Charlie: please try again but use 2 storeviews only and not 2 websites + 2 stores + 2 storeviews. The expectation is that there will be 2 url rewrites generated...