Pieter Hoste
Pieter Hoste
Hi @jorgb90: can you give me some more info about this particular situation? The tool will already remove any file which isn't referenced in the database, so even if duplicated...
Aha okay, it makes sense now. Do the database entries use the exact same filename for global and storeview values? Or are the files also duplicated on disk with a...
Nice! Good job! @fredden: can you add https://github.com/magento/magento2/issues/38217 to the description of this PR? As this fixes that issue, so it automatically gets closed when this PR is merged. I...
For some reason, this PR wasn't marked as merged, even though the code was merged recently here: https://github.com/magento/magento2/commit/808253df82fcfa653e851ef0224ab33837b2ad65
I don't know if there are valid cases for having multiple spaces inside an html attribute value, but this PR would break that I think. The `preg_replace` solution is maybe...
For some reason, this PR wasn't marked as merged, even though the code was merged (cherry-picked?) recently here: https://github.com/magento/magento2/commit/c6d91bdf2468a104ffef556cb51031959bf245ff
Hmm, let's hold on a bit and see what the response is from https://github.com/colinmollenhour/php-redis-session-abstract/issues/58, I'm pretty sure the change will be reverted, maybe they'll release a 2.0.0 with this change,...
So, since version 1.7.0 of `colinmollenhour/php-redis-session-abstract` has been released (which has the same code as 1.5.5) and version 2.0.0 now is the same as 1.6.0, this PR should be updated...
Thanks @TuVanDev, can you also update the title of the PR with the correct version? And maybe remove the patch instructions from the description, it's not longer relevant as a...
For some reason, this PR wasn't marked as merged, even though the code was merged (via [cherry-picking](https://github.com/magento/magento2/commit/341f8c0a51938414c32bf5d28a3a84b353f87b65)) recently as part of this bigger merge: https://github.com/magento/magento2/commit/1bafc5712abd635395f0bcfe24ea3f198c18f615