Pieter Hoste

Results 348 comments of Pieter Hoste

Just took a look at a Magento 2.1.7 and 2.1.11 shop, in 2.1.7 it was still configurable on storeview level, in 2.1.11 it no longer is. So this got changed...

It only makes sense to configure `custom_instructions` differently if you use different domain names and want a different `/robots.txt` "file" per domain name. But it looks like you can configure...

@engcom-Bravo: please don't advise people to use chmod 0777, it could introduce security problems. @sdzhepa, @sidolov: can you guys have a word with your support people so they no longer...

Let is be noted that there is a competing PR with the same changes over here: https://github.com/magento/magento2/pull/38261 Both got approved, so we should halt one of them and only proceed...

@serhii-chernenko: wasn't this already fixed in https://github.com/magento/magento2/pull/28415? This is to be released in Magento 2.4.7, I agree that it took a very long time before it got picked up, but...

The unit error can be fixed by adding some parenthesis, like this: ```diff diff --git a/lib/web/css/source/lib/variables/_typography.less b/lib/web/css/source/lib/variables/_typography.less index e357b6969db..177b061323b 100644 --- a/lib/web/css/source/lib/variables/_typography.less +++ b/lib/web/css/source/lib/variables/_typography.less @@ -29,10 +29,10 @@ @font-size-ratio__base: 1.4;...

The following downgrades make less compilation with grunt work without errors: ```diff diff --git a/package.json.sample b/package.json.sample index 9fbde04e8a7..faa6cb7ff47 100644 --- a/package.json.sample +++ b/package.json.sample @@ -18,7 +18,7 @@ "grunt-contrib-cssmin": "~4.0.0", "grunt-contrib-imagemin":...

@serhii-chernenko, please re-read [my earlier comment](https://github.com/magento/magento2/pull/38109#issuecomment-1773748984): > @serhii-chernenko: wasn't this already fixed in https://github.com/magento/magento2/pull/28415? This is to be released in Magento 2.4.7, I agree that it took a very long...

Great, @serhii-chernenko, do you want to update your PR with my suggested downgrades? Or should we open a new one?

I still think we should change the title & description & manual testing steps of this PR to avoid confusion for anyone that runs against this ticket. The PR is...