Pieter Hoste
Pieter Hoste
I'm not an Varnish expert, so maybe we can pull in one here. @gquintard: what do you think about this fix? For context, this originates from this discussion here: https://github.com/magento/magento2/issues/36492#issuecomment-1321206478...
Awesome! I've cherry-picked your commit and added it to this PR here. I can confirm the test passes with the fixes provided here and fails without them.
Not many session related changes at first sight: https://github.com/magento/magento2/compare/2.4.6-p2..2.4.6-p3 Maybe one of the recent changes in these 3 repositories causes it? - https://github.com/colinmollenhour/php-redis-session-abstract - https://github.com/colinmollenhour/Cm_Cache_Backend_Redis - https://github.com/colinmollenhour/credis
I just noticed this commit made in core magento that limits 2 of the redis packages to a certain version (according to the commit message - in broken English -...
@shkodasv: I think you have a very valid point here. @engcom-Bravo: in my opinion this is a bug and I'll re-open this ticket for now, feel free to discuss if...
This was also proposed in https://github.com/magento/magento2/pull/36796, but since it [lacked feedback from Adobe people](https://github.com/magento/magento2/pull/36796#issuecomment-1493796859) it got closed. Maybe taking things in smaller steps will have a bigger chance of being...
Not sure if it is the same issue, but there is a bug in Magento 2.4.x (not in 2.3.x) with the indexers where the partial indexer could loop unnecessarily many...
@amouri82: Start from the diff of the PR: https://patch-diff.githubusercontent.com/raw/magento/magento2/pull/36155.diff And see if you can apply that as a patch (you'll have to convert the paths so you can apply it...
Honestly, I find that this doesn't improve readability at all, like when you see `ManagerInterface`, what does it mean? I think proper aliases should be used if the claim is...
This might be a bit more complex than what it sounds like. See https://github.com/OpenMage/magento-lts/pull/1036 where an attempt is made to apply a similar change to Magento 1, it contains a...