react-native-dropdown-picker icon indicating copy to clipboard operation
react-native-dropdown-picker copied to clipboard

Published 20 hours ago • verified publisher icon hossein-zare

feat: Add customItemValueDelimiter

Open JHeigle opened this issue 2 years ago • 3 comments

Hey @hossein-zare, saw a potential small issue with the custom item value .replace() modifier for spaces. This update will allow users to customize the delimiter for the value saved when selecting a custom item and make sure that the delimiter is implemented in all space instances.

  • The value for the customItemValueDelimiter defaults to what was already in place (-).
  • .replace() was replaced (no pun intended) with .replaceAll().

Helps resolve issue #604.

Thank you for your feedback!

JHeigle avatar May 15 '23 03:05 JHeigle

This is great, thanks, could it be merged please?

jacklj avatar Jul 10 '23 23:07 jacklj

This is great and helps solve the issue I was having #604

I was looking into this same thing and was struggling to figure out why the space to dash replacement was necessary at all. Do you know what the purpose of the replacement is? For my use, I'd like to maintain the spaces in my items, but I'm not sure if this is going to break the library?

joshzeldin avatar Dec 31 '23 15:12 joshzeldin