horilla
horilla copied to clipboard
Anniversary Date Leave Reset
Added a feature to assign an anniversary date to an employee. Added database features to save anniversary date Added Anniversary date based reset for leave types Added Anniversary date field to employee work info Added Scheduling functions to reset anniversary based reset on employees anniversary date. Other bug fixes
⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard. Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.
🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 16050831 | Triggered | Generic Password | 75d67b6a71fb8731ba057da5a9d057325d6e18f3 | biometric/dahua.py | View secret |
| 16050832 | Triggered | Generic Password | 75d67b6a71fb8731ba057da5a9d057325d6e18f3 | biometric/dahua.py | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Ok. I think I got it this time... both the accounts showing in here are mine.
The secrets it says are there are not my file, so not sure why it's showing that?
@JVKeller create a new branch and make pull from horilla master and then work there not press sync button on git this will cause the error again and again
Hey @horilla-opensource, just checking in to see if there was something I needed to do or this was just waiting for you to find the time to go through it.
I noticed you added a 'hired date' field on Apr.1. That's kind of like the anniversary date field that I made.
Hi @JVKeller ,
We are reviewing your code .
Once it completed and ready for the merge , We will inform you
Hi @JVKeller,
We have reviewed your code and noticed a few updates that are needed.
Please make sure to apply your changes on top of the latest Horilla codebase, as some files in your pull request do not contain the most recent updates.
In the employee/templates/employee/profile/work_info.html file, the label for the {{ work_form.anniversary_date }} field is incorrect. In your pull request, the label for the anniversary_date field is shown as "Contract End Date", which appears to be a mismatch.
Could you please correct this and update your pull request accordingly?
Best Regards, Team Horilla
Hi @JVKeller,
We have reviewed your code and noticed a few updates that are needed.
Please make sure to apply your changes on top of the latest Horilla codebase, as some files in your pull request do not contain the most recent updates.
In the
employee/templates/employee/profile/work_info.htmlfile, the label for the{{ work_form.anniversary_date }}field is incorrect. In your pull request, the label for theanniversary_datefield is shown as "Contract End Date", which appears to be a mismatch.Could you please correct this and update your pull request accordingly?
Best Regards, Team Horilla
Updated...
Not sure why yet, but when I update my fork with the changes from the horilla repo, they stopped updating in my local repo. Trying to get that fixed up without messing up my production branch! I was hoping to get this merged in so I could just rebuild my local copies...
Is this pull request able to be merged/compatible with the pending new release?