horilla icon indicating copy to clipboard operation
horilla copied to clipboard

Hour Account > Minus hours calculations? > Not Approved OT Hours still shown

Open borishinzer opened this issue 2 years ago • 59 comments

Is there a way to see a total summary of either overtimes or minus hours per day, week, month - and also transfer those to the next month or to reset them, in case overtimes were paid?

Also, similar to overtimes, minus hours should be reported and approved by a supervisor.

borishinzer avatar Aug 11 '23 22:08 borishinzer

Hi @borishinzer , Currently we do not have this feature added in our system. We are planning to adding it the upcoming updates. Once done, we'll update you with it. With Regards, Team Horilla

horilla-opensource avatar Aug 16 '23 07:08 horilla-opensource

Any update on this feature? IMO it would only be showing either overtimes or undertimes (minus hours) in hour account.

borishinzer avatar Oct 06 '23 07:10 borishinzer

Hi @borishinzer , Not presently. We have it in our queue. Sorry for the delay. With Regards, Team Horilla

CybroOdooDev avatar Oct 06 '23 08:10 CybroOdooDev

Any update on this issue? This would be really awesome to integration as it would be our final issue (and fix for https://github.com/horilla-opensource/horilla/issues/54) to move completely to Horilla in favour of Kimai, which we used formerly.

borishinzer avatar Oct 23 '23 10:10 borishinzer

Hi @borishinzer , We get your concern. We'll get back to you with the solution to this by the end of this week. Sorry for the delay to this.

With Regards, Team Horilla

horilla-opensource avatar Oct 23 '23 10:10 horilla-opensource

Hi @borishinzer , We have updated the hour calculation method. Please check the commit Please refer the video for the workflow.

https://github.com/horilla-opensource/horilla/assets/131998600/e5e11082-36fe-4eed-a6f3-3a67375f445e

With Regards, Team Horilla

horilla-opensource avatar Nov 01 '23 11:11 horilla-opensource

Hi @borishinzer , Any updates on the above solution?

With Regards, Team Horilla

horilla-opensource avatar Nov 09 '23 04:11 horilla-opensource

Do I get this right? Pending hours are "minus hours" (if the employee worked too few hours in one month / period). Also, if the times are validated then they are taking into account, resulting in either overtimes or "pending hours"?

borishinzer avatar Nov 30 '23 09:11 borishinzer

Hi @borishinzer , Yes, pending hours are considered as minus hours. If attendance with pending hours are validated, then it is considered for the monthly account. Similarly in the case of overtime. Only once approved, it'll be added to the accounts.

horilla-opensource avatar Nov 30 '23 10:11 horilla-opensource

Cool. We are checking it for this for November. It would be good to show this column also to employees in the "My Attendances" .

borishinzer avatar Nov 30 '23 10:11 borishinzer

Sure, will add that.

horilla-opensource avatar Nov 30 '23 10:11 horilla-opensource

Hi @borishinzer , We have added the column for viewing the pending hours in My Attendances. Screenshot 2023-12-01 at 3 56 01 PM

Please check.

With Regards, Team Horilla

horilla-opensource avatar Dec 01 '23 10:12 horilla-opensource

Awesome. Checking now our time tracking for November and will update the issue here.

borishinzer avatar Dec 01 '23 11:12 borishinzer

Seems last update broke the validation somehow. I try to validate various entries, but they stay for validation.

borishinzer avatar Dec 01 '23 11:12 borishinzer

Are you getting any kind of error notifications or is it its just not getting validated even after clicking the validate button?

CybroOdooDev avatar Dec 01 '23 11:12 CybroOdooDev

No error, time entry stays in tab "Validate Attandance". We even get a success message. Same behaviour under Actions.

borishinzer avatar Dec 01 '23 11:12 borishinzer

Tried in Firefox incognito mode - issue stays the same. Where to find the logs?

borishinzer avatar Dec 01 '23 12:12 borishinzer

Hi @borishinzer , Sorry for the delay. We were able to reproduce the issue mentioned above from our side and we have made a fix for it.

Please check: [FIX] ATTENDANCE: Attendance validation issue

The issue was with the validation methods. There was an existing request pending for that corresponding attendance. So on validating it was causing the issue. In the new workflow user will be given a warning if there is an existing request pending prior to validation and user can view the corresponding request from that view where they will be able to approve it.

Screenshot 2023-12-02 at 2 22 09 PM

With Regards, Team Horilla

horilla-opensource avatar Dec 02 '23 08:12 horilla-opensource

Still not completely fixed. I get the request and then head over to "approve" the time entry, which doesn't change anything. If I "edit" and "save" the record without changing anything, it will get automatically approved.

borishinzer avatar Dec 02 '23 10:12 borishinzer

You can find a video of the issue here: https://cloud.web-vision.de/index.php/s/oN7RMiNHXP4Fz7H

borishinzer avatar Dec 02 '23 10:12 borishinzer

Additional: it seems that sometime "approval" is working and sometimes not.

borishinzer avatar Dec 02 '23 10:12 borishinzer

Sure, we'll check and update the solution asap.

horilla-opensource avatar Dec 02 '23 11:12 horilla-opensource

Still not completely fixed. I get the request and then head over to "approve" the time entry, which doesn't change anything. If I "edit" and "save" the record without changing anything, it will get automatically approved.

Hi @borishinzer , Could you check with the latest commits for the fix?

horilla-opensource avatar Dec 03 '23 07:12 horilla-opensource

We didn't validate the time calculations yet, as we needed a full month of time trackings before. Our people are now actively testing Horilla based on the time trackings for November, December. Our aim is to report bugs and improvements and start using Horilla only (as substitute for Kimai) with beginning of November.

At this point I would like to says THANK YOU for your incredible work and your fast responses. This is really awesome 🙏

borishinzer avatar Dec 06 '23 10:12 borishinzer

Hi @borishinzer , Thanks for taking your time in testing out Horilla and providing us with your suggestions to improve our system. We are ready to assist you in all the support needed for setting up Horilla in your side. Please feel free to contact us with any queries. ([email protected])

With Regards, Team Horilla

horilla-opensource avatar Dec 06 '23 10:12 horilla-opensource

Hi @borishinzer , Any updates on the issue fix?

With Regards, Team Horilla

horilla-opensource avatar Mar 19 '24 05:03 horilla-opensource

Still not working properly. I have validated all times of an employee and also approved his overtimes. Still the hour account shows wrong values and pending approvals. Bildschirmfoto 2024-03-28 um 10 39 00

borishinzer avatar Mar 28 '24 09:03 borishinzer

Any updates on this task?

borishinzer avatar Sep 03 '24 07:09 borishinzer

Hi @borishinzer , We have made changes for the calculation methods in our previous commits. Can you confirm with the latest commits if its fixed for you ?

We apologize for not providing an update on the same.

With Regards, Team Horilla

horilla-opensource avatar Sep 05 '24 11:09 horilla-opensource

Hey @horilla-opensource, Seems that the Times are still not showen correctly in the Hour Account.

Here you can see that Overtime is 0:00. Screenshot 2024-09-26 at 10 09 56

When you go into the Day View Overtime are shown - /attendance/attendance-search?employee_id=10&attendance_validated=true&attendance_date__gte=2024-07-01&attendance_date__lte=2024-07-31

Screenshot 2024-09-26 at 10 12 14

Riiiad avatar Sep 26 '24 08:09 Riiiad