ochi icon indicating copy to clipboard operation
ochi copied to clipboard

Fixed layout should be dynamic

Open glaslos opened this issue 2 years ago • 6 comments

The App.svelte has a lot of hard-coded layout glory. This makes is rather difficult to add new layout elements without breaking the current layout. Even adding new pages would be challenging. Here are some offenders:

Redo the layout allowing for:

  • Dynamically resize the window
  • Adding more elements (like separating the right column)
  • Adding a new page (e.g. rule management, user profile...)

glaslos avatar Feb 22 '23 17:02 glaslos

Hi @glaslos, I want to work on this, can you please elaborate on what is really required in this? I understood that the layout needs to be modified in order to allow for more elements and pages, I didn't understand the second paragraph on what really needs to be done.

aditygrg2 avatar Feb 23 '23 18:02 aditygrg2

Have a look at the current layout definition. A lot of it depends on hard coded values defining the size of e.g. the header and the columns. The layout should be more elastic and based on the size of the content instead. E.g. We could allow for the divider between the left and right column to be manually adjustable. The header growing in size with more dynamic content being added.

glaslos avatar Feb 23 '23 20:02 glaslos

Hi @glaslos, Thank you, I am facing some issues in implementing the sockets in localhost here : https://github.com/glaslos/ochi/blob/5e76a4b36ee9c532fbddb57a8455c1c550d3c9f5/src/App.svelte#L52

Also, I would like to contribute to GSoC this year, any issues or suggestions for understanding the codebase better will help me a lot, if you can suggest.

aditygrg2 avatar Feb 24 '23 19:02 aditygrg2

Can you elaborate on your issues with the websockets? Are you running the backend server?

glaslos avatar Feb 25 '23 09:02 glaslos

Hello @glaslos,

I have thought of an idea to maintain newer pages, as well as improve the current page layout. The wireframes are below: before_click

After clicking on any event, the payload may appear separately on the right portion, the user can close or open it according to his/her needs.

after_click

We can implement more pages, in the left portion. Is this a good solution to this, do you have other suggestions/additions to this?

aditygrg2 avatar Mar 02 '23 14:03 aditygrg2

@glaslos I would like to work on this!

ashutosh887 avatar Sep 06 '23 07:09 ashutosh887