honeybadger-ruby icon indicating copy to clipboard operation
honeybadger-ruby copied to clipboard

Support Rails 7' error reporting interface

Open shalvah opened this issue 3 years ago • 0 comments

Closes https://github.com/honeybadger-io/honeybadger-ruby/issues/416

Error reporter API doc

Re the source parameter (new in v7.1):

  • Added a new config option so users can automatically ignore certain sources
  • Only (two internal sources)(https://sourcegraph.com/search?q=context:global+ActiveSupport.error_reporter%26.report+repo:rails/rails&patternType=standard) currently used in Rails, and they're both for cache, so ignored them (and similar others) by default.
  • Noticed there's a source parameter in the Honeybadger ingest API spec, but it seems to be a weird object, so I think using a source: tag is more useful here.

Will send docs PR after this is merged.

image

image

image

shalvah avatar Aug 06 '22 23:08 shalvah

The overall strategy looks pretty good to me 👍🏼

I am a little leary about using tags for some of this data though. I don't know if we want to relegate tags to a bucket of error attributes, especially since some of this data feels like key / value data. Also, since tags have some prominence in the UI (we show them in the list view) I don't think we want to have a tag like handled:true, which as a user, I don't think I will know what that means.

Another thing I noticed is we don't allow the ":" as a tag character when editing in the UI. We do allow it from the API side, however. So, currently, if a user edits those tags they will be saved with the colons stripped.

rabidpraxis avatar Aug 10 '22 18:08 rabidpraxis

This looks fine to me. I'm ambivalent about the tags concern that Kevin has. However, if we are going to start adding tags with a colon, then we should change the UI to allow for colons, too.

stympy avatar Aug 10 '22 18:08 stympy