honeybadger-python icon indicating copy to clipboard operation
honeybadger-python copied to clipboard

Include method arguments in backtrace

Open joshuap opened this issue 4 years ago • 4 comments

I believe Python makes method arguments available to each stack frame in the traceback. Is that correct? If so, I'd like to include the arguments in the Honeybadger backtrace, as we do for Elixir (see filter_args option).

This feature should be enabled when a new filter_args is set to false. The default should be true so that args are not included by default. We'll ship this as an opt-in feature in the next minor version; I may enable it by default in the next major version.

Also, what other data is available in the traceback/stack frame that we could be including?

Resources

Front logo Front conversations

joshuap avatar Jun 18 '21 19:06 joshuap

this is related 👍 to #122

remstone7 avatar Nov 04 '22 18:11 remstone7

Addressed with #123

Kelvin4664 avatar Nov 14 '23 12:11 Kelvin4664

@Kelvin4664 @subzero10 I don't think this was addressed with #123, because this issue was to add local variables at the stack frame level in the traceback, whereas #123 added local variables for the top-level call. Is that right? If so, we should keep this open, assuming it's technically feasible.

joshuap avatar Nov 27 '23 22:11 joshuap

@Kelvin4664 @subzero10 I don't think this was addressed with #123, because this issue was to add local variables at the stack frame level in the traceback, whereas #123 added local variables for the top-level call. Is that right? If so, we should keep this open, assuming it's technically feasible.

Oh, you are right! Good catch!

subzero10 avatar Nov 28 '23 06:11 subzero10