honeybadger-python icon indicating copy to clipboard operation
honeybadger-python copied to clipboard

Published 20 hours ago • verified publisher icon honeybadger-io

why are Flask dependencies installed on Django build?

Open dotysan opened this issue 2 years ago • 4 comments

Example Job

Or more specifically, why does this script blindly install Flask dependencies--and even Flask itself--when $FLASK_VERSION isn't set.

dotysan avatar Jun 02 '23 01:06 dotysan

Hey @Kelvin4664, any thoughts on this?

subzero10 avatar Jun 02 '23 08:06 subzero10

I've simplified the script in this branch, and am having no issues with CI.

dotysan avatar Jun 04 '23 16:06 dotysan

@dotysan Can you please create PR from your branch to see what's been done and what's pending? It seems that you are tackling a couple of open issues, let's see if can address them all with a single PR.

subzero10 avatar Jun 06 '23 05:06 subzero10

Done in fresh branch here #153. Take a peek and review!

dotysan avatar Jun 08 '23 00:06 dotysan