honeybadger-js icon indicating copy to clipboard operation
honeybadger-js copied to clipboard

window.onerror [RECURSION] exception

Open ntalbott opened this issue 3 years ago • 10 comments

What are the steps to reproduce this issue?

  1. Install the Honeybadger library to catch client-side JS errors.
  2. Get lots of these errors.

What happens?

Screen Shot 2022-04-22 at 1 09 31 PM Screen Shot 2022-04-22 at 1 10 09 PM

What were you expecting to happen?

No error, or a useful error report.

Any logs, error output, etc?

See above.

Any other comments?

I think this in honeybadger.js since so far as I know I don't have any other onerror handlers installed.

What versions are you using?

See screenshots.

Front logo Front conversations

ntalbott avatar Apr 22 '22 17:04 ntalbott

Can you take a look at this, @subzero10? I wonder if something is throwing an object that we're flagging as recursive.

joshuap avatar Apr 22 '22 19:04 joshuap

Yes, sure. It would help if I could have some example code. I also noticed that the honeybadger client is not the latest version. @ntalbott can you please try with the latest stable version (v3.2.9) or the beta version (v4.0) ? Thanks!

subzero10 avatar Apr 22 '22 20:04 subzero10

Can you take a look at this, @subzero10? I wonder if something is throwing an object that we're flagging as recursive.

In order to flag one as recursive, it means that we are serializing an object that we've already seen (since the moment we call the sanitize method). The best way to debug this would be a reproducible example.

cc @ntalbott @joshuap

subzero10 avatar Apr 24 '22 12:04 subzero10

@subzero10 I wish I could easily give you a reproduction, but this is a consumer product and this issue is happening enough to be more than noise but not enough for me to have ever seen it in the wild.

What's the best way to get the latest version of the JS library? Even hitting the url in the docs (js.honeybadger.io/v3.2/honeybadger.min.js) I'm getting 3.2.8, not 3.2.9.

ntalbott avatar Apr 25 '22 14:04 ntalbott

@ntalbott sorry about that—stale CDN cache, it seems. It should be 3.2.9 now.

joshuap avatar Apr 25 '22 17:04 joshuap

OK, updated to 3.2.9, and even after burn-in, doesn't seem to have affected the rate of these (~100 hr, varied over time).

One question: with this getting thrown up to the HoneyBadger API, would an error message still get printed out to the console in the browser? Will try to keep an eye out if so and see if I can catch this in the wild.

ntalbott avatar Apr 25 '22 18:04 ntalbott

One question: with this getting thrown up to the HoneyBadger API, would an error message still get printed out to the console in the browser? Will try to keep an eye out if so and see if I can catch this in the wild.

Yes an error message should be printed out to the console. You can also enable more verbose logging by setting debug: true when configuring Honeybadger.

subzero10 avatar Apr 25 '22 20:04 subzero10

Hey @ntalbott, is this still an issue for you?

subzero10 avatar Aug 12 '22 11:08 subzero10

In the last week we’ve seen it 5-20 times/day, pretty much every day.

— Nathaniel <:((><

On Aug 12, 2022, at 7:32 AM, Pangratios Cosma @.***> wrote:

Hey @ntalbott https://github.com/ntalbott, is this still an issue for you?

— Reply to this email directly, view it on GitHub https://github.com/honeybadger-io/honeybadger-js/issues/760#issuecomment-1213016209, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAABX5VGM26AWTS2IQIRI3VYYY6VANCNFSM5UC46F5A. You are receiving this because you were mentioned.

ntalbott avatar Oct 11 '22 08:10 ntalbott

Have you tried setting debug: true ? Did you see any logs reported?

subzero10 avatar Oct 19 '22 12:10 subzero10