Style Changes to Increase Visibility of Temperatures

[mcmspark]

On small displays the temperature is hard to read. This increases the size of the fonts and expands the width of the temperature circle on accessory widgets.

(I did accidentally use a work github account initially to apply and then revert the change)

[Feilner]

Personally I prefer the version with the circle as it is in line with the home app design. But I agree that on small displays it's not as easy to see as in the home app. I would recommend to change to a better readable font or bold format.

Homebridge

Home App

If readability on small displays also the humidity visualization needs to be updated.

Another option would be to offer different visualizations and let the user choose.

[mcmspark]

I did consider a larger change to allow skins and custom styles, but it is unclear if that is a desired outcome here, as it could give rise to a diverse user experience.

[bwp91]

Personally I like this update. Makes the temperature (and humidity @mcmspark I assume is the same?) clearer.

Personally I prefer the version with the circle as it is in line with the home app design

I also understand this opinion, but (im having to think about this!) the homebridge ui was always meant as a helpful tool for homebridge rather than a 'replacement' for the home app.

any opinion @NorthernMan54 , this is considering this PR is still something to look at and also would need to be rebased against master branch.

[NorthernMan54]

@bwp91 - Why don't we release this as part of the beta, and collect feedback from the wider user community. Personally I prefer the larger fonts as they are easier to read. And am thinking we leave the humidity characteristic for a further release during the beta. This will allow for a direct comparison.

PS - I'm like you and rarely use the accessories tab, except for troubleshooting issues.

[bwp91]

Hi @mcmspark happy to put this into a beta version. I have rebasd this already onto a beta branch.

My last question is - are the screenshots needed as part of the PR, or can these be binned?

[donavanbecker]

We could make this an option with config ui options? So we could keep both sides happy. Thoughts?

[coveralls]

Pull Request Test Coverage Report for Build 5674725848

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.4%) to 43.779%

---

Totals
Change from base Build 5610788690:	0.4%
Covered Lines:	2123
Relevant Lines:	4507

---

💛 - Coveralls

[bwp91]

@donavanbecker my thought on this is to not have a config option. don't wanna open a can of worms on this - for me the least number of config options the better. I personally like these changes. I think putting this into a beta release would be great. But i do think the screenshots as part of this PR are not needed.

[mcmspark]

Thanks Ben, it is so long ago. I thought I posted screenshots with the PR. I can look if I still have them.

Sent from my iPhone

On Jul 19, 2023, at 8:42 PM, Ben @.***> wrote:



Hi @mcmsparkhttps://github.com/mcmspark happy to put this into a beta version. I have rebasd this already onto a beta branch.

My last question is - are the screenshots needed as part of the PR, or can these be binned?

— Reply to this email directly, view it on GitHubhttps://github.com/homebridge/homebridge-config-ui-x/pull/1300#issuecomment-1642943142, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AC5P77SPKPYFKMSTDOQXCILXRB5IHANCNFSM5QTYZ4GQ. You are receiving this because you were mentioned.Message ID: @.***>

[bwp91]

Thanks Ben, it is so long ago. I thought I posted screenshots with the PR. I can look if I still have them.

I mean - the screenshots were helpful to see what this PR was gonna do, but I don't this that they need to be part of the PR files

[mcmspark]

I do love options. As long as it is clear how and what to choose.

On Jul 19, 2023, at 9:36 PM, Donavan Becker @.***> wrote:



We could make this an option with config ui options? So we could keep both sides happy. Thoughts?

— Reply to this email directly, view it on GitHubhttps://github.com/homebridge/homebridge-config-ui-x/pull/1300#issuecomment-1642976870, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AC5P77XGSMS2RBFWMVVZKQDXRCDRRANCNFSM5QTYZ4GQ. You are receiving this because you were mentioned.Message ID: @.***>

[donavanbecker]

@mcmspark We don’t need options just thought I would throw it out there.

[donavanbecker]

I think once the screenshots are removed from the PR we would be good to go to merge this.

[bwp91]

@mcmspark i'm quite looking forward to this PR and trying it out with my very disorganised homebridge ui! once the screenshots are removed we can look to merge in 🚀

[donavanbecker]

@mcmspark please remove screenshots so we can merge this.