HAP-NodeJS
HAP-NodeJS copied to clipboard
homebridge
Please Merge New Types for WaterQuality
:recycle: Current situation
Water Quality Sensors are not supported
:bulb: Proposed solution
Add a Service and Characteristics to allow Water Quality Sensors to be supported.
:gear: Release Notes
New Types added. No breaking changes.
:heavy_plus_sign: Additional Information
Testing
Reviewer Nudging
Create a new WaterQualityService and add the new Characteristics to it.
When was this service introduced? Are they documented anywhere? The files the PR changes are auto generated normally. The sources from which we auto generate those files don't include the updated service. Otherwise, the generator tool also includes the ability to manually define these inputs.
Pull Request Test Coverage Report for Build 4572154496
- 36 of 61 (59.02%) changed or added relevant lines in 2 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage decreased (-0.09%) to 64.957%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| src/lib/definitions/CharacteristicDefinitions.ts | 32 | 44 | 72.73% |
| src/lib/definitions/ServiceDefinitions.ts | 4 | 17 | 23.53% |
| <!-- | Total: | 36 | 61 |
| Totals | |
|---|---|
| Change from base Build 3709412126: | -0.09% |
| Covered Lines: | 7432 |
| Relevant Lines: | 10650 |
💛 - Coveralls
going to close this PR as there hasn't been any movement for over a year. If you would like to provide documentation as @Supereg requested then we can revisit this.
