RFC: Add Makefile variable for Supervisor channel

[agners]

trafficstars

Allow to set the release channel pre-installed Home Assistant components like Supervisor and add-on are fetched from. This channel is then also used at runtime.

Summary by CodeRabbit

• New Features

  • Introduced a new variable to specify the HASSIO package channel during the build process.
  • Added support for dynamic channel selection in the installation scripts.
  • Created a JSON file to store the selected channel information.

• Improvements

  • Updated URLs to fetch HASSIO version dynamically based on the selected channel.

[agners]

I was considering making this a package config, like so:

--- a/buildroot-external/package/hassio/Config.in
+++ b/buildroot-external/package/hassio/Config.in
@@ -18,4 +18,10 @@ config BR2_PACKAGE_HASSIO_MACHINE
        help
          Machine to pull containers for (used for landing page).
 
+config BR2_PACKAGE_HASSIO_CHANNEL
+       string "Default Channel"
+       default "beta"
+       help
+         Channel to use by default.
+
 endif

But then it can't be overriden from Makefile (at least it didn't work for me :thinking: ).

I think we should rename the variable to BR2_EXTERNAL_HASSIO_CHANNEL or something if we want to go with the overrideable variant.

[coderabbitai[bot]]

[!CAUTION]

Review failed

The pull request is closed.

📝 Walkthrough

📝 Walkthrough

Walkthrough

The pull request introduces a new configuration option BR2_PACKAGE_HASSIO_CHANNEL for the Hass.io package in the Buildroot environment, allowing users to specify the default channel for the Supervisor App. The create-data-partition.sh script is updated to accept a channel parameter, which is passed to the dind-import-containers.sh script. This script now creates a JSON file containing the channel information. Additionally, the HASSIO_VERSION_URL in the hassio.mk file is modified to utilize the BR2_PACKAGE_HASSIO_CHANNEL variable for dynamic version retrieval.

Changes

File	Change Summary
buildroot-external/package/hassio/Config.in	Added new configuration options for channel selection: BR2_PACKAGE_HASSIO_CHANNEL_STABLE, BR2_PACKAGE_HASSIO_CHANNEL_BETA, BR2_PACKAGE_HASSIO_CHANNEL_DEV.
buildroot-external/package/hassio/create-data-partition.sh	Modified to accept channel as the third argument.
buildroot-external/package/hassio/dind-import-containers.sh	Introduced variable channel from the first argument. Created JSON file at /data/supervisor/updater.json with channel information.
buildroot-external/package/hassio/hassio.mk	Updated HASSIO_VERSION_URL to use $(BR2_PACKAGE_HASSIO_CHANNEL). Updated output filenames from stable.json to version.json in HASSIO_CONFIGURE_CMDS and HASSIO_BUILD_CMDS. Added $(BR2_PACKAGE_HASSIO_CHANNEL) to create-data-partition.sh in HASSIO_INSTALL_IMAGES_CMDS.

[!WARNING]

Rate limit exceeded

@agners has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 3 minutes and 27 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 8cfa907c0cf9a366cc8373e8ee20781f0a71055b and c21cca3fe2c083b6a3e24092dd3b3377142bbe08.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.