home-assistant.io icon indicating copy to clipboard operation
home-assistant.io copied to clipboard

Add mention of email in the HTML5 notification doc

Open thibaultmol opened this issue 1 year ago • 6 comments

Feedback

I started to use the integration for the first time and I was (and frankly still am) VERY confused why an html push notification integration needs my emailadres. It would be nice if the docs explained this because currently it's not even mentioned anywhere

URL

https://www.home-assistant.io/integrations/html5/

Version

2024.10.2

Additional information

No response

thibaultmol avatar Oct 17 '24 06:10 thibaultmol

Hey there @alexyao2015, mind taking a look at this feedback as it has been labeled with an integration (html5) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of html5 can trigger bot actions by commenting:

  • @home-assistant close Closes the feedback.
  • @home-assistant rename Awesome new title Renames the feedback.
  • @home-assistant reopen Reopen the feedback.
  • @home-assistant unassign html5 Removes the current integration label and assignees on the feedback, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information) to the feedback.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information) on the feedback.

home-assistant[bot] avatar Oct 17 '24 06:10 home-assistant[bot]

(also unrelated but: it seems like there is some funkyness to using it with Nabu Casa. I also can't get it working : https://community.home-assistant.io/t/remote-access-nabu-casa-push-notifications/107099/6 ) I got it setup but can't actually get any notifications get sent (probably because of similar issues but I can't figure out what to do). So maybe the docs need some stuff about Nabu Casa setups

thibaultmol avatar Oct 17 '24 06:10 thibaultmol

See this https://blog.mozilla.org/services/2016/08/23/sending-vapid-identified-webpush-notifications-via-mozillas-push-service/

The email itself isn't actually validated, so you could theoretically use any random email.

alexyao2015 avatar Oct 17 '24 07:10 alexyao2015

Interesting, is there a way why home assistant doesn't just generate a random one for you then?

thibaultmol avatar Oct 17 '24 07:10 thibaultmol

That would be bad practice and against spec

alexyao2015 avatar Oct 17 '24 07:10 alexyao2015

ok. so in that case I guess it's best to mention this in the docs and explain.

And maybe also worth looking into the problem with Nabu Casa users which might need some more configuring to get it working?

thibaultmol avatar Oct 17 '24 07:10 thibaultmol

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved. If this issue is still relevant, please let us know by leaving a comment 👍 This issue has now has been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Dec 16 '24 08:12 github-actions[bot]