home-assistant.io icon indicating copy to clipboard operation
home-assistant.io copied to clipboard

Remove API Key instructions from Hydrawise docs

Open dknowles2 opened this issue 1 year ago • 1 comments

Proposed change

Remove the prerequisites section from the Hydrawise docs that discuss the need to obtain an API Key. This is no longer necessary with https://github.com/home-assistant/core/pull/106904 as you can now simply authenticate using username & password.

Type of change

  • [ ] Spelling, grammar or other readability improvements (current branch).
  • [ ] Adjusted missing or incorrect information in the current documentation (current branch).
  • [ ] Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • [ ] Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • [x] Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase: https://github.com/home-assistant/core/pull/106904
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • [x] This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • [x] The documentation follows the Home Assistant documentation standards.

dknowles2 avatar Apr 27 '24 15:04 dknowles2

Deploy Preview for home-assistant-docs ready!

Name Link
Latest commit 6063caae391046b126deba78798f11ac0b29a522
Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/6637aed377f03b0008c50e87
Deploy Preview https://deploy-preview-32488--home-assistant-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Apr 27 '24 15:04 netlify[bot]

Let's rebase this to current so we can get this in. If you ever notice that we forget to merge the docs (or label it for that matter) but the feature did, be sure to let us know on discord :)

joostlek avatar May 05 '24 13:05 joostlek

Let's rebase this to current so we can get this in. If you ever notice that we forget to merge the docs (or label it for that matter) but the feature did, be sure to let us know on discord :)

I note that because I authenticate via Apple, I don’t have a password. Does this mean I have to create a new account using my email address to use this integration now? Or is there some way to get the authentication dialog in the integration linked to the Apple authentication page?

arohl avatar May 05 '24 14:05 arohl

It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the next branch. Please change the target branch of this PR to next and rebase if needed.

home-assistant[bot] avatar May 05 '24 16:05 home-assistant[bot]

Let's rebase this to current so we can get this in. If you ever notice that we forget to merge the docs (or label it for that matter) but the feature did, be sure to let us know on discord :)

Done.

dknowles2 avatar May 05 '24 16:05 dknowles2

Let's rebase this to current so we can get this in. If you ever notice that we forget to merge the docs (or label it for that matter) but the feature did, be sure to let us know on discord :)

I note that because I authenticate via Apple, I don’t have a password. Does this mean I have to create a new account using my email address to use this integration now? Or is there some way to get the authentication dialog in the integration linked to the Apple authentication page?

Let's discuss in https://github.com/home-assistant/core/issues/116830#issuecomment-2094807709

dknowles2 avatar May 05 '24 16:05 dknowles2