home-assistant.io icon indicating copy to clipboard operation
home-assistant.io copied to clipboard

Traccar integration: Improve variables description

Open AndreKR opened this issue 3 years ago • 5 comments

Feedback

I just finished setting up the Traccar integration and I want to propose two documentation changes that would have saved me some headaches:

https://www.home-assistant.io/integrations/traccar/

Configuration variable username currently says:

The username for the Traccar server.

I propose to change it to:

The email address of the Traccar user.

This is because the field must be set to the email adress and not to the name of the user in Traccar:

image

Configuration variable ssl currently says:

Use HTTPS to connect to Traccar server. NOTE A host cannot be an IP address when this option is enabled.

I propose to add another note:

Note that this does not automatically set the port to 443.

This is because usually when you have an "SSL" option the port will be set based on that but here you have to set the port manually.

Also, if you don't set the port correctly, you will not get an error message. Only if you enable debug logging you will simply see repeated "DEBUG (MainThread) [homeassistant.components.traccar.device_tracker] Testing connection to Traccar" log entries.

URL

https://www.home-assistant.io/integrations/traccar/

Version

I cannot find the version number

Additional information

No response

AndreKR avatar Jul 14 '22 11:07 AndreKR

Hey there @ludeeus, mind taking a look at this feedback as it has been labeled with an integration (traccar) you are listed as a code owner for? Thanks! (message by CodeOwnersMention)

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved. If this issue is still relevant, please let us know by leaving a comment 👍 This issue has now has been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Sep 12 '22 12:09 github-actions[bot]

github-actions bot closed this as completed

That is a bit... misleading.

I could prepare a PR if there's a chance it'll get merged?

AndreKR avatar Sep 19 '22 14:09 AndreKR

IMO I do not think these should be changed. The integration should get a config flow instead.

ludeeus avatar Sep 19 '22 14:09 ludeeus

The integration should get a config flow instead.

Ah, I see. That's a bit beyond my current Python skills unfortunately.

AndreKR avatar Sep 19 '22 14:09 AndreKR

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved. If this issue is still relevant, please let us know by leaving a comment 👍 This issue has now has been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Nov 18 '22 15:11 github-actions[bot]