baf integration AssertionError

[purcell-lab]

The problem

With the upgrade to beta I am seeing an Assertion Error with the BAF integration.

What version of Home Assistant Core has the issue?

core-2023.6.0b

What was the last working version of Home Assistant Core?

core-2023.5

What type of installation are you running?

Home Assistant Supervised

Integration causing the issue

baf

Link to integration documentation on our website

https://www.home-assistant.io/integrations/baf

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

Logger: homeassistant
Source: /usr/src/homeassistant/homeassistant/runner.py:137
First occurred: June 4, 2023 at 5:41:38 PM (494 occurrences)
Last logged: 7:21:36 AM

Error doing job: Exception in callback Device.async_run.<locals>.stop_on_cancel(<Future cancelled>) at /usr/local/lib/python3.11/site-packages/aiobafi6/device.py:401
Traceback (most recent call last):
  File "/usr/local/lib/python3.11/asyncio/events.py", line 80, in _run
    self._context.run(self._callback, *self._args)
  File "/usr/local/lib/python3.11/site-packages/aiobafi6/device.py", line 403, in stop_on_cancel
    self._stop()
  File "/usr/local/lib/python3.11/site-packages/aiobafi6/device.py", line 443, in _stop
    self._sched_connect_or_signal_run_fut()
  File "/usr/local/lib/python3.11/site-packages/aiobafi6/device.py", line 267, in _sched_connect_or_signal_run_fut
    assert self._connect_timer is None
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError

Additional information

One fan is offline, no power, the others seem functional.

[home-assistant[bot]]

Hey there @bdraco, @jfroy, mind taking a look at this issue as it has been labeled with an integration (baf) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of baf can trigger bot actions by commenting:

• @home-assistant close Closes the issue.
• @home-assistant rename Awesome new title Renames the issue.
• @home-assistant reopen Reopen the issue.
• @home-assistant unassign baf Removes the current integration label and assignees on the issue, add the integration domain after the command.

_{^{(message by CodeOwnersMention)}}

---

baf documentation baf source _{^{(message by IssueLinks)}}

[bdraco]

Is the fan reachable on the local network?

[purcell-lab]

Is the fan reachable on the local network?

One fan is offline without power, so it is not reachable.

Others seem functional.

[bdraco]

It looks like the lib needs to change the assertion when the fan is offline. I don't think will actually hurt anything besides generate log spam.