core
core copied to clipboard
home-assistant
Add Schlage integration
Proposed change
This adds a new integration for Schlage WiFi locks. This first PR is a bare-bones implementation of the custom integration I've been maintaining at https://github.com/dknowles2/ha-schlage/. I'll port the remaining features in subsequent PRs to make the reviews manageable.
Type of change
- [ ] Dependency upgrade
- [ ] Bugfix (non-breaking change which fixes an issue)
- [x] New integration (thank you!)
- [ ] New feature (which adds functionality to an existing integration)
- [ ] Deprecation (breaking change to happen in the future)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [ ] Code quality improvements to existing code or addition of tests
Additional information
- This PR fixes or closes issue: fixes #
- This PR is related to issue:
- Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/27585
Checklist
- [x] The code change is tested and works locally.
- [x] Local tests pass. Your PR cannot be merged unless tests pass
- [x] There is no commented out code in this PR.
- [x] I have followed the development checklist
- [x] I have followed the perfect PR recommendations
- [x] The code has been formatted using Black (
black --fast homeassistant tests) - [x] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [x] Documentation added/updated for www.home-assistant.io
If the code communicates with devices, web services, or third-party tools:
- [x] The manifest file has all fields filled out correctly.
Updated and included derived files by running:python3 -m script.hassfest. - [x] New or updated dependencies have been added to
requirements_all.txt.
Updated by runningpython3 -m script.gen_requirements_all. - [x] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
- [ ] Untested files have been added to
.coveragerc.
To help with the load of incoming pull requests:
- [ ] I have reviewed two other open pull requests in this repository.
Once review has started, please don't force push as it makes it very hard to figure out what has changed
Once review has started, please don't force push as it makes it very hard to figure out what has changed
Ack, sorry about that!
Ugh. Once again I seem to have tripped over git's terrible UX.
I rebased and force pushed and I think this is fixed now.
If there's a lot of work left here I suggest starting over in a new PR to avoid spamming all the participants that were brought in by mistake when the rebase went wrong.
been traveling and just got back home. I'll catch up on reviews as soon as I can
This one looks like its nearly ready to merge. There are some tiny review comments and has_entity_name needs to be set
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:
Learn more about our pull request process.
![home-assistant[bot] avatar](https://avatars.githubusercontent.com/in/97978?v=4 "Published by a pub.dev verified publisher"){kind=small}
Is everything still working ok if you delete and re setup?
Yep, seems to work.
The config flow has 100% coverage so we can merge when the CI is green.
If you don't want to add the additional coverage, please add the files to .coveragerc for the ones the ci is failing on. (Would be better to add the coverage)
The config flow has 100% coverage so we can merge when the CI is green.
If you don't want to add the additional coverage, please add the files to .coveragerc for the ones the ci is failing on. (Would be better to add the coverage)
Should have 100% coverage now.