core icon indicating copy to clipboard operation
core copied to clipboard

Add Xiaomi Miio deerma.humidifier.jsq2w

Open mislavbasic opened this issue 2 years ago • 3 comments

Proposed change

This change adds support for deerma.humidifier.jsq2w to xiaomi integration.

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [x] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

I added support for this humidifier so I don't have to use community integration that I'm using currently which imports humidifier into home assistant as "fan" instead of humidifier. Current version of 'python-miio' that is being used in home-assistant Xiaomi integration throws warning every time it communicates with deerma.humidifier.jsq2w saying that it's not supported but integration still works normally. Because of that annoying warning I submitted code to 'python-miio' repository that removes it when using deerma.humidfier.jsq2w. That PR has already been merged today, you can find it here: rytilahti/python-miio#1748. When new version of that library is pushed and bumped in home-assistant, warning will be gone.

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] The code has been formatted using Black (black --fast homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

mislavbasic avatar Feb 26 '23 22:02 mislavbasic

Hi @mislavbasic

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

home-assistant[bot] avatar Feb 26 '23 22:02 home-assistant[bot]

Hey there @rytilahti, @syssi, @starkillerog, mind taking a look at this pull request as it has been labeled with an integration (xiaomi_miio) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of xiaomi_miio can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign xiaomi_miio Removes the current integration label and assignees on the pull request, add the integration domain after the command.

home-assistant[bot] avatar Feb 26 '23 22:02 home-assistant[bot]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Feb 27 '23 10:02 home-assistant[bot]

@mislavbasic Would you complete this PR, or do you need any help with it? I would be happy to have this integration added.

swingerman avatar Mar 27 '23 07:03 swingerman

Hi @swingerman, it's not up to me. We are waiting for python-miio lib to release a new version which will contain code that I pushed to their repository. My PR on that repo is already merged to master, new version just needs to be released and bumped in home assistant. When this is done, python-miio won't throw warnings anymore and then this will be merged.

As I understood, release of new python-miio version is taking a bit longer since it's being refactored currently.

mislavbasic avatar Apr 16 '23 10:04 mislavbasic

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

github-actions[bot] avatar Jul 15 '23 11:07 github-actions[bot]