core
core copied to clipboard
Add cloud support to IntelliFire Integration
Proposed change
IntelliFire offers both cloud and local integration support. Unfortunately for some people it seems the cloud integration can be more reliable - due to the IOT hardware seeming to drop local network traffic, prioritizing its cloud based connection. This change adds in support for the Cloud based read/control in conjunction with the local. As such there is a large update in the backing library.
This is the diff between versions of the backing library https://github.com/jeeftor/intellifire4py/compare/2.2.2...v3.1.5
The updated backing library allows the user to switch between CLOUD and LOCAL for both reading and controlling a fireplace. This is now supported via an options flow as seen here:
Type of change
- [x] Dependency upgrade
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New integration (thank you!)
- [x] New feature (which adds functionality to an existing integration)
- [ ] Deprecation (breaking change to happen in the future)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [ ] Code quality improvements to existing code or addition of tests
Additional information
- This PR fixes or closes issue: fixes #
- This PR is related to issue:
- Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/26671
Checklist
- [x] The code change is tested and works locally.
- [x] Local tests pass. Your PR cannot be merged unless tests pass
- [x] There is no commented out code in this PR.
- [x] I have followed the development checklist
- [x] The code has been formatted using Black (
black --fast homeassistant tests) - [x] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [x] Documentation added/updated for www.home-assistant.io
If the code communicates with devices, web services, or third-party tools:
- [x] The manifest file has all fields filled out correctly.
Updated and included derived files by running:python3 -m script.hassfest. - [x] New or updated dependencies have been added to
requirements_all.txt.
Updated by runningpython3 -m script.gen_requirements_all. - [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
- [ ] Untested files have been added to
.coveragerc.
To help with the load of incoming pull requests:
- [x] I have reviewed two other open pull requests in this repository.

Pretty sure the failing pip-check is no fault of mine...
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:
I cleaned up the commit history - and downgraded some versions and it looks like everything is passing 👏🏼
Let's start by making sure the CI passes. Currently, there is a new version/dependency conflict introduced by this PR which needs to be fixed.
We're passing! :)
I believe I fixed the conflicts. I also corrected Intellifire to IntelliFire in the process. I think that got messed up on the rebase...
During merging also discovered an issue with my httpx version in the backing lib ... so had to bump the backing lib...
Back to you guys :)