core icon indicating copy to clipboard operation
core copied to clipboard

Add virtual integrations for intellifire compatible fireplaces

Open jeeftor opened this issue 2 years ago • 2 comments

Proposed change

The following fireplace brands are IntelliFire Compatible - and as such I wanted to make virtual integrations for them.

image

If you need me to back this out and just do each integration one-by-one that's fine - but I also thought maybe because its just virtual ones I could do this as a single PR

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [x] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Brand Icon PRs:

  • https://github.com/home-assistant/brands/pull/4154
  • https://github.com/home-assistant/brands/pull/4155
  • https://github.com/home-assistant/brands/pull/4156
  • https://github.com/home-assistant/brands/pull/4157
  • https://github.com/home-assistant/brands/pull/4158
  • https://github.com/home-assistant/brands/pull/4159

Checklist

  • [ ] The code change is tested and works locally.
  • [ ] Local tests pass. Your PR cannot be merged unless tests pass
  • [ ] There is no commented out code in this PR.
  • [ ] I have followed the development checklist
  • [ ] The code has been formatted using Black (black --fast homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [x] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

jeeftor avatar Feb 23 '23 17:02 jeeftor

Question:

Is documentation required for Virtual integrations?

jeeftor avatar Feb 23 '23 18:02 jeeftor

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Feb 27 '23 14:02 home-assistant[bot]