core
core copied to clipboard
Add Overkiz Hitachi DHW
Breaking change
Proposed change
Implement Overkiz Hitachi DHW, a Water Heater entity provided by Hitachi.
Type of change
- [ ] Dependency upgrade
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New integration (thank you!)
- [X] New feature (which adds functionality to an existing integration)
- [ ] Deprecation (breaking change to happen in the future)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [ ] Code quality improvements to existing code or addition of tests
Additional information
This is a port from Ha-Tahoma entity Please note that I cannot test it myself.
- This PR fixes or closes issue: fixes #
- This PR is related to issue:
- Link to documentation pull request:
Checklist
- [ ] The code change is tested and works locally.
- [X] Local tests pass. Your PR cannot be merged unless tests pass
- [X] There is no commented out code in this PR.
- [X] I have followed the development checklist
- [X] The code has been formatted using Black (
black --fast homeassistant tests) - [ ] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [ ] Documentation added/updated for www.home-assistant.io
If the code communicates with devices, web services, or third-party tools:
- [ ] The manifest file has all fields filled out correctly.
Updated and included derived files by running:python3 -m script.hassfest. - [ ] New or updated dependencies have been added to
requirements_all.txt.
Updated by runningpython3 -m script.gen_requirements_all. - [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
- [ ] Untested files have been added to
.coveragerc.
To help with the load of incoming pull requests:
- [ ] I have reviewed two other open pull requests in this repository.
Hey there @imicknl, @vlebourl, @tetienne, mind taking a look at this pull request as it has been labeled with an integration (overkiz) you are listed as a code owner for? Thanks!
Code owner commands
Code owners of overkiz can trigger bot actions by commenting:
@home-assistant closeCloses the issue.@home-assistant rename Awesome new titleChange the title of the issue.@home-assistant reopenReopen the issue.@home-assistant unassign overkizRemoves the current integration label and assignees on the issue, add the integration domain after the command.
@tetienne @iMicknl Regaring the porting of the code, I updated
OverkizCommand.SET_CONTROL_DHW, OverkizCommandParam.RUN
became :
OverkizCommand.SET_CONTROL_DHW, OverkizCommandParam.ON
(OverkizCommandParam.RUN doesn not seem to exists and I could not find any setup exemple with this device in json tests)
current_operation return STATE_OFF instead of OverkizCommandParam.OFF
which is basically the same, both constate avec the same value OFF, but it's stricter regarding HA.